Skip an API call when downloading a CodeQL version with a semver bundle #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we made an API call to look up the CLI version to release mapping when the default CLI version was requested on Dotcom and that CLI wasn't in the toolcache. Now we compute the tag name directly for semver bundles.
henrymercer
force-pushed
the
henrymercer/bundle-semantic-version-simplifications
branch
from
db2aa0a to
6418c5d
Compare
angelapwen
approved these changes
Jul 7, 2023
henrymercer
deleted the
henrymercer/bundle-semantic-version-simplifications
branch
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we made an API call to look up the CLI version to release mapping when the default CLI version was requested on Dotcom and that CLI wasn't in the toolcache. Now we compute the tag name directly for semver bundles.
Merge / deployment checklist