Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to TypeScript 9.2.0 #1492

Merged
merged 11 commits into from
Jan 20, 2023
Merged

Upgrade to TypeScript 9.2.0 #1492

merged 11 commits into from
Jan 20, 2023

Conversation

henrymercer
Copy link
Contributor

Now that we've dropped Node 12 support, we can upgrade to the latest version of TypeScript!

  • I've brought a bunch of other packages up to date, since we need to update our linter and test suite to be compatible with the new TypeScript version.
  • I've added type annotations to account for the stricter type checking that's now enabled.
  • I've bumped our compilation target from ES2019 to ES2021 (see https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping).

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner January 18, 2023 20:59
@henrymercer henrymercer mentioned this pull request Jan 18, 2023
Closed
@henrymercer
Remove Node 12 compatibility check
d5dcff5
@henrymercer
Add a .DS_Store file shipped with a dependency
4306b97 
We should be checking in all contents of the dependencies, including OS
junk!
@henrymercer henrymercer mentioned this pull request Jan 18, 2023
Merged
6 tasks
@henrymercer
Copy link
Contributor Author

@github/codeql-action-reviewers This is ready for review. The two checks that are still yellow have been removed, and we'll need to update the required checks prior to merging.

aeisenberg
aeisenberg reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This was really hard to review since the PR tools in the browser just wasn't loading the code for me. Or I had to wait 10-15 seconds for rendering.

src/codeql.ts Outdated Show resolved Hide resolved
src/codeql.ts Outdated Show resolved Hide resolved
src/autobuild-action.ts Outdated Show resolved Hide resolved
src/init-action.ts Outdated Show resolved Hide resolved
src/upload-sarif-action.ts Outdated Show resolved Hide resolved
aeisenberg
aeisenberg reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments for typing, but I think it's basically good.

aeisenberg
aeisenberg approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/codeql.ts Show resolved Hide resolved
@henrymercer henrymercer merged commit 4827181 into main Jan 20, 2023
@henrymercer henrymercer deleted the henrymercer/upgrade-typescript branch January 20, 2023 16:28
@github-actions github-actions bot mentioned this pull request Jan 26, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @aeisenberg