Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set testing environment for CodeQL workflow #1374

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

henrymercer
Copy link
Contributor

Previously we simply disabled uploading the status reports for all PR checks except ones that were there specifically to test the status report functionality. However when there's a lot of development activity on the CodeQL Action repo and the Actions runtime is being flaky, it's valuable being able to completely exclude CodeQL Action development from telemetry queries.

As drive-by improvements, this PR also makes TEST_MODE specific to the CodeQL Action and enables it in the check-codescanning-config Action. We also remove the INTERNAL_CODEQL_ACTION_DEBUG_LOC variable, which is redundant as of #1358.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner November 16, 2022 16:26
@henrymercer henrymercer force-pushed the henrymercer/pass-testing-environment branch from 1e73af3 to a836d95 Compare November 16, 2022 16:40
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, CODEQL_ACTION_TEST_MODE is much clearer to me 👍

@henrymercer henrymercer merged commit 0f07790 into main Nov 16, 2022
@henrymercer henrymercer deleted the henrymercer/pass-testing-environment branch November 16, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants