Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt customers to upgrade from v1 to v2 #1045

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Apr 26, 2022

This PR will add a warning on jobs that (a) use a v1 CodeQL Action and (b) run on a GitHub instance that supports v2 of the CodeQL Action. This warning states that v1 will be deprecated on 7th December 2022 and prompts these customers to upgrade to v2.

Example run with old version of the Action in an upgradeable environment: https://github.com/github/codeql-action/actions/runs/2239513990

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner April 26, 2022 15:53
src/util.ts Outdated Show resolved Hide resolved
@henrymercer henrymercer marked this pull request as draft April 26, 2022 17:03
@henrymercer henrymercer force-pushed the henrymercer/prompt-v1-to-v2-upgrades branch from 77bca35 to 0256599 Compare April 27, 2022 15:11
@henrymercer henrymercer marked this pull request as ready for review April 27, 2022 15:18
src/util.ts Outdated Show resolved Hide resolved
src/util.ts Outdated Show resolved Hide resolved
src/util.ts Show resolved Hide resolved
src/util.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided @aeisenberg is also happy.

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very happy.

@henrymercer henrymercer merged commit 0c3c093 into main Apr 28, 2022
@henrymercer henrymercer deleted the henrymercer/prompt-v1-to-v2-upgrades branch April 28, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants