-
Notifications
You must be signed in to change notification settings - Fork 339
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allows us to analyze and then check that certain queries were included in the analysis and others were not.
- Loading branch information
1 parent
29a2159
commit bcb7fad
Showing
3 changed files
with
120 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
name: Check SARIF | ||
description: Checks a SARIF file to see if certain queries were run and others were not run. | ||
inputs: | ||
sarif-file: | ||
required: true | ||
description: The sarif file to check | ||
|
||
queries-run: | ||
required: true | ||
description: | | ||
Comma separated list of query ids that should be included in this SARIF file. | ||
queries-not-run: | ||
required: true | ||
description: | | ||
Comma separated list of query ids that should NOT be included in this SARIF file. | ||
runs: | ||
using: node12 | ||
main: index.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
'use strict' | ||
|
||
const core = require('@actions/core'); | ||
const fs = require('fs') | ||
|
||
const sarif = JSON.parse(fs.readFileSync(core.getInput('sarif-file'), 'utf8')) | ||
const rules = sarif.runs[0].tool.extensions.flatMap(ext => ext.rules || []) | ||
|
||
// Expected Queries | ||
const expectedQueriesRun = getInput('queries-run') | ||
const queriesThatShouldHaveRunButDidnt = expectedQueriesRun.reduce((acc, queryId) => { | ||
if (!rules.some(rule => rule.id === queryId)) { | ||
acc.push(queryId) | ||
} | ||
return acc | ||
}, []); | ||
|
||
if (queriesThatShouldHaveRunButDidnt.length > 0) { | ||
core.setFailed(`The following queries were expected to run but did not: ${queriesThatShouldHaveRunButDidnt.join(', ')}`) | ||
} | ||
|
||
// Unexpected Queries | ||
const expectedQueriesNotRun = getInput('queries-not-run') | ||
|
||
const queriesThatShouldNotHaveRunButDid = expectedQueriesNotRun.reduce((acc, queryId) => { | ||
if (rules.some(rule => rule.id === queryId)) { | ||
acc.push(queryId) | ||
} | ||
return acc | ||
}, []); | ||
|
||
if (queriesThatShouldNotHaveRunButDid.length > 0) { | ||
core.setFailed(`The following queries were NOT expected to have run but did: ${queriesThatShouldNotHaveRunButDid.join(', ')}`) | ||
} | ||
|
||
|
||
core.startGroup('All queries run') | ||
rules.forEach(rule => { | ||
core.info(`${rule.id}: ${(rule.properties && rule.properties.name) || rule.name}`) | ||
}) | ||
core.endGroup() | ||
|
||
core.startGroup('Full SARIF') | ||
core.info(JSON.stringify(sarif, null, 2)) | ||
core.endGroup() | ||
|
||
function getInput(name) { | ||
return core.getInput(name) | ||
.split(',') | ||
.map(q => q.trim()) | ||
.filter(q => q.length > 0) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
name: Expected queries runs | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
- releases/v1 | ||
- releases/v2 | ||
pull_request: | ||
types: | ||
- opened | ||
- synchronize | ||
- reopened | ||
- ready_for_review | ||
workflow_dispatch: {} | ||
|
||
jobs: | ||
expected-queries: | ||
timeout-minutes: 45 | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out repository | ||
uses: actions/checkout@v3 | ||
- name: Prepare test | ||
id: prepare-test | ||
uses: ./.github/prepare-test | ||
with: | ||
version: latest | ||
- uses: ./../action/init | ||
with: | ||
languages: javascript | ||
tools: ${{ steps.prepare-test.outputs.tools-url }} | ||
- uses: ./../action/analyze | ||
with: | ||
output: ${{ runner.temp }}/results | ||
upload-database: false | ||
upload: false | ||
env: | ||
TEST_MODE: true | ||
|
||
- name: Check Sarif | ||
uses: ./../action/.github/check-sarif | ||
with: | ||
sarif-file: ${{ runner.temp }}/results/javascript.sarif | ||
queries-run: js/incomplete-hostname-regexp,js/path-injection | ||
queries-not-run: foo,bar |