Skip to content

Commit

Permalink
python-setup: Fail early if installing for Python 2, and python2 no…
Browse files Browse the repository at this point in the history
…t available
  • Loading branch information
RasmusWL committed Sep 21, 2022
1 parent 3f97671 commit 1fa5d72
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions python-setup/auto_install_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import subprocess
from tempfile import mkdtemp
from typing import Optional
import shutil

import extractor_version

Expand Down Expand Up @@ -154,6 +155,17 @@ def install_packages(codeql_base_dir) -> Optional[str]:
# get_extractor_version returns the Python version the extractor thinks this repo is using
version = extractor_version.get_extractor_version(codeql_base_dir, quiet=False)

if version == 2 and not sys.platform.startswith('win32'):
# On Ubuntu 22.04 'python2' is not available by default. We want to give a slightly better
# error message than a traceback + `No such file or directory: 'python2'`
if shutil.which("python2") is None:
sys.exit(
"package installation failed: we detected this code as Python 2, but 'python2' executable was not available."
"To enable automatic package installation, please install 'python2' before the 'github/codeql-action/init' step, "
"such as running 'sudo apt install python2' (Ubuntu 22.04)."
"If your code is not Python 2, but actually Python 3, please file a bug report at https://github.com/github/codeql-action/issues/new"
)

if os.path.exists('requirements.txt'):
print('Found requirements.txt, will install packages with pip', flush=True)
return install_requirements_txt_packages(version)
Expand Down

0 comments on commit 1fa5d72

Please sign in to comment.