-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tasklist extension #94
Conversation
This extension is working well for me on Linux. It looks like the AppVeyor build is failing because compiler warnings are treated as errors and the two unused variables in the no-op _scan_tasklist function are generating warnings. One suggestion I have is to include a element for the task item content so that replacement of the input form element can be done with pure CSS a la this StackOverflow thread. |
cb839a4
to
b91798f
Compare
Hey @Watson1978, out of curiosity -- would supporting tri-state checkboxes be in-scope for this extension? The lack of an indeterminate or N/A state has been a consistent point of friction for me in GitHub's current implementation. |
c69ba25
to
a243d1b
Compare
Any chance this gets picked up? It is the only thing missing for me to switch to this library for markdown rendering. |
> Two list items are of the same type if they begin with a list marker of the same type. Two list markers are of the same type if (a) they are bullet list markers using the same character (-, +, or *) or (b) they are ordered list numbers with the same delimiter (either . or )). ( https://github.github.com/gfm/#task-list-items-extension- )
It makes sense. I'll test this and merge. |
Added some tests and addressed bugs that showed as a result. |
@Watson1978 Let me know what name you'd like to be used in attribution for this PR for the changelog and releases! |
Likewise, let me know if you need a new release made. |
@kivikakk Thank you for merging this!! I prefer that you will use my github account name :) |
Because github/cmark-gfm#94 was merged
Any chance to have a new version released because of this? |
@doits I've tagged the release |
@kivikakk thanks! |
* add tasklist extension * recognize “+” as list marker * use long type to avoid warning in MSVC environment * recognize ordered list > Two list items are of the same type if they begin with a list marker of the same type. Two list markers are of the same type if (a) they are bullet list markers using the same character (-, +, or *) or (b) they are ordered list numbers with the same delimiter (either . or )). ( https://github.github.com/gfm/#task-list-items-extension- ) * add preliminary tests * fix regular extension tests * fix tasklist nesting
This patch will parse Task list items (extension) in GitHub Flavored Markdown Spec.