Fix TextMate Scope for '.ice' Files #6714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm the maintainer of the Slice language!
A few months ago, we released a new 'edition' of our language's syntax, so there are now 2 separate syntaxes for Slice.
By convention, the original syntax uses (and has always used)
.ice
file suffixes. The new syntax uses.slice
file suffixes.Due to the difference in syntax, each uses it's own highlighter. You can see them here:
https://github.com/zeroc-ice/vscode-slice/tree/main/syntaxes
Note that this is already the grammar repo used by Linguist:
linguist/vendor/README.md
Line 517 in fd10bee
As part of this change, we modified the TM scope associated with
.ice
files fromsource.slice
tosource.ice
(so we could use the
source.slice
TM scope for the new syntax).This change took place here: zeroc-ice/vscode-slice@ab6bf2d
I acknowledge this is probably a fairly unorthodox thing to do, so any guidance on what's the best way to proceed would be appreciated! But, as the absolute least, I opened this PR because the highlighting for
.ice
files is currently broken, as they're pulling in the TM scope for the new syntax.Checklist:
This isn't changed by this PR.