Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo/error in CONTRIBUTING.md #5559

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix typo/error in CONTRIBUTING.md #5559

merged 1 commit into from
Sep 7, 2021

Conversation

Astroide
Copy link
Contributor

@Astroide Astroide commented Sep 7, 2021

As opposed to most of the possessive forms, it's does not mean something that belongs to it. it's is a contraction of it is, and the correct way to write something that belongs to it is its.

Old sentence :
This often results in someone grasping the opportunity to create a newer and better and more actively maintained grammar, and we'd love to use it and pass on it's functionality to our users.. That meant This often results in someone grasping the opportunity to create a newer and better and more actively maintained grammar, and we'd love to use it and pass on it is functionality to our users., which I think was not the intended meaning.

Therefore, I changed the it's into an its:
This often results in someone grasping the opportunity to create a newer and better and more actively maintained grammar, and we'd love to use it and pass on its functionality to our users.

Checklist:

  • I am associating a language with a new file extension.
  • I am adding a new language.
  • I am fixing a misclassified language
  • I am changing the source of a syntax highlighting grammar
  • I am updating a grammar submodule
  • I am adding new or changing current functionality
  • I am changing the color associated with a language

None of the above applies. I am simply fixing an error in CONTRIBUTING.md.

As opposed to most of the possessive forms, `it's` does not mean something that belongs to `it`. `it's` is a contraction of `it is`, and the correct way to write something that belongs to `it` is `its`.
@Astroide Astroide requested a review from a team as a code owner September 7, 2021 16:49
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!! It's only taken nearly four years for someone to spot my mistake 🤣

I'll look into the Docker build failure later.

@lildude lildude merged commit f7b64b5 into github-linguist:master Sep 7, 2021
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants