-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Nim's colour #4900
Change Nim's colour #4900
Conversation
For curious people - image with all colours which can be used for language colours (I picked #deb012 from this one): |
Nice the matrix style rendering! I also like a lot this rendering (which shows large black blobs of invalid colors): https://github.com/PMunch/colourfinder #ffc200 was picked from that thin line between yellow and orange. |
@pietroppeter yeah, I used @PMunch's colourfinder but modified it a bit to process images in parallel with Weave and output a HSV-sorted gradient image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve.
The comments on this language colour topic yesterday, and some free time, prompted me to finally do something about it. I've created https://lildude.github.io/linguist-free-colours/ and opened #4903 for feedback. |
Nice, but what about this PR ? :) |
We normally work on the basis that one of the community maintainers will review all PRs before I put my final stamp on it and merge it. |
There's also no hurry for PRs to be merged as they don't go live until I make a release, which I aim to do approximately monthly, though that can slip if other things take priority. |
Last time another PR got merged before us and we lost a colour, so there might be a bit of a hurry :) |
Description
This PR is a follow-up to #4866 (#4871) with a different color
From
#37775b
to#ffc200
Checklist:
I hope this time this colour would be good enough since it was checked against the same algo as GitHub's color proximity.