-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Haxe generated source detection #4808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gama11 where did all the fixture files come from and how are they licensed?
Please add the source and license to the OP for this PR.
@lildude I simply compiled a Hello World program to different targets with Haxe 4.0.5: class Main {
static function main() {
trace("Hello World");
}
} e.g. Not sure a license makes any sense for that? :) |
Indeed, which is why we always ask for samples from real-world applications. It also helps train the classifier. |
Well, I can certainly swap them out with something else if you prefer, though for what is being tested here (just the source header comments) it doesn't really make any difference, other than increasing file size... |
🤔 thanks for the explanation @Gama11. Yeah, I think in this case, it makes sense for these samples as is. Thanks. |
Description
The Haxe compiler can generate source files for a whole host of different target languages. It's fairly simple to detect this with the
Generated by Haxe <version>
comment the files start with. I've included test files for all relevant targets that Haxe 4 supports.Checklist: