Accept and encourage "minus-prefix" for unset gitattributes as per gitattributes documentation #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie this from the gitattributes docs:
Unset
The path has the attribute with special value "false"; this is specified by listing the name of the attribute prefixed with a dash `-` in the attribute list.
This was referenced Jan 23, 2020
lildude
commented
Jan 23, 2020
| # README.md linguist-documentation=false | ||
| # samples/Arduino/* linguist-documentation | ||
| # samples/Markdown/*.md linguist-detectable=true | ||
| # samples/HTML/*.html linguist-detectable=false |
There was a problem hiding this comment.
The four lines above have been added to the .gitattributes in the test branch but this side hasn't been update to reflect this, so I'm adding them as part of this PR.
pchaigno
approved these changes
Jan 23, 2020
|
@lildude friendly reminder to update https://help.github.com/en/github/administering-a-repository/customizing-how-changed-files-appear-on-github to use (I haven't searched recently to see if there are other GitHub doc pages that need updating.) |
|
I'll let our docs team know. |
It seems that they forgot to change that in this place:
|
|
Not really. It still works. Not sure what happened to me original issue. I'll see if I can find time to dig it up, but there's no urgency. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@cespare rightly pointed out in #4624 that we're being "special" by requiring people to use the
falsestring to negate or unset a behaviour via.gitattributesand really should accept and encourage the "minus-prefixed"-linguist-whatevermethod for unsetting/negating.As per the gitattributes documentation:
@cespare got the ball rolling with updating the documentation and I've now implemented the necessary code changes in this PR for the negation to work. This covers both the gitattributes documented behaviour and our old
=falsebehaviour so we don't catch anyone by surprise.The setting/enabling part already works so no changes on that side.
This PR needs the changes in #4779.
Checklist: