-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color for MLIR #4726
Add color for MLIR #4726
Conversation
That color is actually conflicting with MQL4's. From the Travis CI logs:
Do you have other ideas of colors? If not, we could simply add it to #4506. |
The other colors used are #3775E0 (which is too close to MQL5[1] and Slash), #1B466C (I'm not sure I get Is the closeness a problem if these two languages will rarely (ever?) end up in same repo? I can't dismiss the possibility though. But that may be irrelevant for current policy. [1] Why does MQL4 and MQL5 have different colors? Given they are using the same tm_scope and same grammar (but different file extensions) it seem unfortunate given the color different requirement. Esp. given different versions of Python or C++ do not have this difference. If MQL4 shared the same color as MQL5 then it would resolve the conflict on the current suggestion. But this is probably an aside. |
Unfortunately, yes. I'm still waiting on the GitHub design team to get back to me about dropping this proximity enforcement. I prod the issue now and then but it's not really high on their priority list. Until we get the clearance, we're going to have to keep this enforcement in place. Whilst you won't be able to get the exact colours used by the language repo, a little tweaking should get you close. |
I just did a quick test and |
Consider revising in case the previous one becomes available.
Yes I can imagine, thanks! I'm good with this suggestion.
SG, that makes sense. I started typing a longer discussion about different approaches, but figured this would be the wrong spot for that :) Is there perhaps a bug I could follow along for this request? This would be for my own curiosity really as I'm happy enough with a distinct color. |
Unfortunately, not. All GitHub issues are currently on the private repo so not open to the public. |
Description
There is currently no color associated with MLIR, I'm changing it to match one of the colors of the logo of the MLIR project.
Checklist: