Sever relationships between CSON/JSON and parent languages #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alhadis
requested review from
pchaigno and
lildude
and removed request for
pchaigno
pchaigno
approved these changes
Dec 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix to decouple CSON and JSON from CoffeeScript and JavaScript, respectively. They're
data-type languages anyway, so they won't affect repository statistics. More importantly, this is part of a long-term cleanup on how we handle language "groups" (see #4291). The reaction I expressed in #4344 at seeing CoffeeScript instead of CSON is as good an indication as any that we're doing the right thing by degrouping them. 👍Fixes: #4344
References: #4291
Template removed as the issue is predominantly about semantics