-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Atom's HTML grammar instead of TextMate's #4274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm always in favor of switching for grammars that have tests!
Tests are great until you need to update 300+ assertions because a scope was added. 😢 Not to mention they're so painful to write, I actually wrote an Atom command to generate them from a tokenised buffer's contents. Which had the oh-so-clever name of "Spec-saver". 👅 |
Build is failing because of another license issue:
Tests passed locally though, so I don't know what's up with that... |
The caching of the license hasn't detected the license is MIT so has set it to "other" when caching. The We know this is MIT so feel free to set it manually in the license file. |
GitHub staff approving the use of GitHub-licensed software for use on GitHub. Are you sure that's safe? |
Not at all 😜 |
No objections here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR replaces the grammar used for HTML highlighting on GitHub.
Description
This is a follow-up to
mariozaizar/language-eml#15
, where @pchaigno observed jarring error highlights being applied to HTML embedded in another grammar (see#4201
). The spurious highlights in question are absent when using Atom's HTML grammar for highlighting.Moreover, Atom's grammar has greatly improved visibility than TextMate's, and is likely to stay updated faster as the HTML spec itself evolves.
Checklist:
No real difference in highlighting, apart from when embedded content is involved. Which, unfortunately, is impossible to demonstrate due to technical limitations of Lightshow.
/cc @50Wliu, @mariozaizar