-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store grammar git version within license file when caching #4268
Changes from 6 commits
892f802
9c68fec
53aa3c2
4368267
c86cfd1
f3ffe62
f120841
de78626
58a5a58
026c6c0
7cf1233
e093035
9de1ebf
aa21330
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,5 @@ | ||
#!/usr/bin/env ruby | ||
|
||
# TODO: push these changes to licensor gem | ||
|
||
require "bundler/setup" | ||
require "licensed/cli" | ||
require "optparse" | ||
|
@@ -24,10 +22,10 @@ module Licensed | |
|
||
def dependencies | ||
Dir.glob(@glob).map do |directory| | ||
puts "caching #{directory}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is duplicating info that is already printed by Licensed. Licensed will print:
|
||
Licensed::Dependency.new(directory, { | ||
"type" => Filesystem.type, | ||
"name" => File.basename(directory) | ||
"name" => File.basename(directory), | ||
"version" => Licensed::Git.version(directory) | ||
}) | ||
end | ||
end | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,9 @@ reviewed: | |
rubygem: | ||
- mime-types | ||
grammar: | ||
- Sublime-Lasso | ||
- blitzmax # No license file. License in README | ||
- creole # License filename is not LICENSE(.*) but rather "The MIT License (MIT)" | ||
- Sublime-Lasso # No license file. License in README | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Equivalent of what we do in test_grammars.rb |
||
|
||
sources: | ||
npm: false | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
--- | ||
type: grammar | ||
name: ABNF.tmbundle | ||
version: 0042b3d7ee21b2f800a8f80d42761513f16d9a52 | ||
license: apache-2.0 | ||
--- | ||
Apache License | ||
Apache License | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤦♂️ ok There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oops. I meant to update our Licensed dependency too. If you're going to address this 🔜, I can hold off merging this PR and update the licenses again once a newer version of Licensed is available. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, I think you may not need to do anything @jonabc. Just updated the gemspec and I'm not seeing that over-stripping of whitespace with Licensed 1.3.3. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmmm, but now the version has changed 😕 Issue in Licensed coming up. |
||
Version 2.0, January 2004 | ||
http://www.apache.org/licenses/ | ||
|
||
|
@@ -203,4 +204,4 @@ license: apache-2.0 | |
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
limitations under the License. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,12 @@ | ||
--- | ||
type: grammar | ||
name: MagicPython | ||
version: fb56c6a98d684e30bed1b0f9647e85741a48f914 | ||
license: mit | ||
--- | ||
The MIT License | ||
|
||
Copyright (c) 2015 MagicStack Inc. http://magic.io | ||
Copyright (c) 2015-present MagicStack Inc. http://magic.io | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
|
@@ -24,3 +25,7 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | |
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
THE SOFTWARE. | ||
|
||
-------------------------------------------------------------------------------- | ||
Victor Petrovykh <[email protected]> | ||
Yury Selivanov <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not going to do this, so no need for this comment.