Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename linguist command to github-linguist #4208

Merged
merged 3 commits into from
Aug 12, 2018
Merged

Conversation

lildude
Copy link
Member

@lildude lildude commented Jul 23, 2018

Description

As pointed out in #3843, when Linguist is installed, it creates a command of bin/linguist which clashes with Qt's bin/linguist.

@smola pointed it in #3843 (comment) that the Debian packages has addressed this by using the name github-linguist.

This PR changes the primary Linguist command from bin/linguist to bin/github-linguist and updates the tests and documentation to reflect this change.

This has been tested on GitHub.com with no adverse effects as it uses the bin/git-linguist command.

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

Fixes #3843

@@ -6,7 +6,7 @@ def rugged_repository
end

def master_oid
'd40b4a33deba710e2f494db357c654fbe5d4b419'
'2a6dd02c6e81b7e30d978806d43d4ba1a7ba8003'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the commit that changed the name from bin/linguist to bin/github-linguist and is needed in order for the test_linguist_breakdown test to reflect the current state of the repo. This change is not essential, but nice to have but less likely to cause confusion later.

@lildude
Copy link
Member Author

lildude commented Aug 12, 2018

Not to self and anyone else who may be making a new Linguist release, this PR and #4222 introduce significant enough changes that a full version bump is called for on the next release.

/cc @kivikakk

@lildude lildude merged commit 7dbcffc into master Aug 12, 2018
@lildude lildude deleted the lildude/rename-linguist-cmd branch August 12, 2018 10:54
This was referenced Aug 15, 2018
@github-linguist github-linguist deleted a comment May 16, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bin/linguist conflicts with Qt5.7
2 participants