Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy languages.yml #4173

Merged
merged 3 commits into from
Jun 25, 2018
Merged

Tidy languages.yml #4173

merged 3 commits into from
Jun 25, 2018

Conversation

lildude
Copy link
Member

@lildude lildude commented Jun 24, 2018

Description

As pointed out in #4172...

  • the codemirror_mime_type and filenames fields are not documented
  • two instances of alias are used instead of aliases
  • a single instance of lexer is left over and was missed in Remove the Pygments dependency #1707

This PR addresses these points.

Checklist:

  • I am adding new or changing current functionality tidying things up
    • I have added or updated the tests for the new or changed functionality.

Gonna investigate how hard it'll be to implement a type of schema validation for the languages.yml file so we can catch things like incorrect use of alias or unused fields.

Fixes #4172

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lildude lildude merged commit b0ecdf3 into master Jun 25, 2018
@lildude lildude deleted the lildude/tidy-languages-yml branch June 25, 2018 08:30
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields in languages.yml
2 participants