Add Wren language #4088

bates64 · 2018-04-03T09:39:38Z

Added the Wren scripting language (grammar & sample). cc @munificent

Checklist:

I am adding a new language.
- The extension of the new language is used in hundreds of repositories on GitHub.com.
  - Search results for each extension:
    - https://github.com/search?utf8=%E2%9C%93&type=Code&ref=searchresults&q=extension%3Awren+wren+NOT+nothack
- I have included a real-world usage sample for all extensions added in this PR:
  - Sample source(s):
  - Sample license(s): MIT
- I have included a syntax highlighting grammar.
- I have included a change to the heuristics to distinguish my language from others using the same extension.

lildude

Thanks for the contribution. Along with addressing my inline comments, you'll need to address the two failing tests too.

Additionally, whilst there are a lot of .wren files, they're only distributed across 19 repos owned by 19 different people so doesn't meet the "used by hundreds of repositories" requirement yet. I've labelled the PR accordingly.

lildude · 2018-04-06T16:05:04Z

samples/Wren/ex.wren

@@ -0,0 +1,15 @@
+System.print("Hello, world!")
+


Linguist needs real-world usage examples to properly train the classifier. "Hello world" code is never real-world usage code. Please replace this with an example of a file from a real project and provide a reference to it and it's license in a comment in the PR.

This might be a good sample file to use: https://github.com/munificent/wrenalyzer/blob/master/parser.wren

MIT license: https://github.com/munificent/wrenalyzer/blob/master/LICENSE

lildude · 2018-04-06T16:09:21Z

vendor/licenses/grammar/wren-sublime.txt

+type: grammar
+name: wren-sublime
+license: other
+---


Can you please update your fork with the latest master, and try replacing the grammar with itself using:

script/add-grammar --replace wren-sublime https://github.com/munificent/wren-sublime

This should hopefully use the new Licensed code to correctly and automatically detect the license.

bates64 · 2018-04-07T10:53:19Z

Looks like licenses are still broken - could this be something to do with wren-sublime using a different header than just "MIT License"? GitHub the site doesn't seem to detect that it's MIT either.

@munificent I notice you use a similar "$project is licensed under the MIT License:" header in a lot of your repositories. Is there a specific reason for this, as it looks like it trips up GH?

bates64 · 2018-04-07T11:06:04Z

@lildude script/add-grammar is failing due to script/list-grammars throwing an error for the scope text.conllu :/

script/list-grammars:81:in `block in to_markdown': undefined method `chomp' for nil:NilClass (NoMethodError)
	from script/list-grammars:65:in `each'
	from script/list-grammars:65:in `to_markdown'
	from script/list-grammars:96:in `update_readme'
	from script/list-grammars:105:in `<main>'

Any ideas?

lildude · 2018-04-12T08:27:27Z

Hmmm, I'm not sure why you're getting that error without seeing the full backtrace.

I'll see if I can reproduce this locally on a clean installation.

Alhadis · 2018-04-12T08:43:21Z

@lildude It's because licensee is throwing an error over a non-absolute system path. It happens in the add-grammar script and leaves Linguist with a half-registered submodule.

This fixes it:

diff --git a/script/add-grammar b/script/add-grammar
index 1d16f063..5a0b0b81 100755
--- a/script/add-grammar
+++ b/script/add-grammar
@@ -111,6 +111,7 @@ log "Confirming license"
 if repo_old
   command('script/licensed')
 else
+  repo_new = File.absolute_path(repo_new)
   command('script/licensed', '--module', repo_new)
 end

lildude · 2018-04-12T09:47:33Z

It's because licensee is throwing an error over a non-absolute system path.

Ahhhh. Makes sense. I like your fix better than mine. ~~Stealing~~ borrowing it for my PR 😉

bates64 · 2018-04-13T16:57:52Z

Tried to apply your fix, @Alhadis, but nothing seems to have changed :/

Deregistering: vendor/grammars/wren-sublime
$ git submodule deinit vendor/grammars/wren-sublime
$ git rm -rf vendor/grammars/wren-sublime
$ script/grammar-compiler update -f
Registering new submodule: vendor/grammars/wren-sublime
$ git submodule add -f https://github.com/munificent/wren-sublime vendor/grammars/wren-sublime
$ script/grammar-compiler add vendor/grammars/wren-sublime
Confirming license
$ script/licensed
Updating grammar documentation in vendor/README.md
$ bundle exec rake samples
$ script/sort-submodules
$ script/list-grammars
  > script/list-grammars:81:in `block in to_markdown': undefined method `chomp' for nil:NilClass (NoMethodError)
  > 	from script/list-grammars:65:in `each'
  > 	from script/list-grammars:65:in `to_markdown'
  > 	from script/list-grammars:96:in `update_readme'
  > 	from script/list-grammars:105:in `<main>'
Command failed. Aborting.

I can try this on a clean branch from master if that might help?

Alhadis · 2018-04-13T17:12:02Z

@heyitsmeuralex It's an issue with your submodules list. Git submodules are managed outside the usual versioning mechanics. Make sure you've merged the latest changes from master, and with your branch checked-out, run script/bootstrap and git submodule sync.

When you hit the error the first time, a submodule was probably registered in your local config, even if it wasn't necessarily checked out in the vendor/grammars directory.

This is I opened #4056 (which has been mostly addressed in #4097). It's a pretty nasty (and less-than-obvious) UX issue.

munificent · 2018-04-16T20:58:06Z

I notice you use a similar "$project is licensed under the MIT License:" header in a lot of your repositories. Is there a specific reason for this, as it looks like it trips up GH?

No specific reason. I've been copy/pasting that file for ages, since long before GitHub even existed, much less detected licenses. :) I can try to fix it to something GitHub can recognize.

lildude · 2018-04-17T07:39:48Z

No specific reason. I've been copy/pasting that file for ages, since long before GitHub even existed, much less detected licenses. :) I can try to fix it to something GitHub can recognize.

That would be ✨ for Linguist but also all the visitors to your repos that use this format for the license file as GitHub will be able to automatically detect the license and add it to the top of the repo just above the language stats bar.

pchaigno · 2018-04-17T07:47:14Z

I can try to fix it to something GitHub can recognize.

Licensee (the GitHub project that detects licenses) uses https://choosealicense.com/ as its primary source for license texts. If you use that formatting for the MIT license, you can be sure it will be recognized by Licensee.

munificent · 2018-04-23T23:51:39Z

OK, I went and fixed the LICENSE files for wren, wrenalyzer, and wren-sublime. I'll eventually work my way through all my various random little repos, but that might take a while. :)

pchaigno · 2018-08-04T14:10:38Z

Closing in favor of #4219. We'll monitor the popularity of the extension there.

If you have an improved search query compared to the one used in #4219, please post it here and I'll update #4219.

Add Wren language

f748028

lildude requested changes Apr 6, 2018

View reviewed changes

lildude added the Pending Popularity label Apr 6, 2018

bates64 added 3 commits April 7, 2018 11:41

Fix Wren color and position in languages.yml

b6a34ca

Merge remote-tracking branch 'origin/master' into wren

77632bd

Use real-world Wren samples

302bf23

lildude mentioned this pull request Apr 12, 2018

Fix adding/replacing a grammar #4097

Merged

2 tasks

pchaigno mentioned this pull request Aug 4, 2018

Extension popularity monitoring #4219

Closed

pchaigno closed this Aug 4, 2018

Nixinova mentioned this pull request May 1, 2021

Wren language support #5349

Closed

github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Wren language #4088

Add Wren language #4088

bates64 commented Apr 3, 2018 •

edited

Loading

lildude left a comment

lildude Apr 6, 2018

munificent Apr 6, 2018

lildude Apr 6, 2018

bates64 commented Apr 7, 2018 •

edited

Loading

bates64 commented Apr 7, 2018 •

edited

Loading

lildude commented Apr 12, 2018

Alhadis commented Apr 12, 2018

lildude commented Apr 12, 2018

bates64 commented Apr 13, 2018

Alhadis commented Apr 13, 2018 •

edited

Loading

munificent commented Apr 16, 2018

lildude commented Apr 17, 2018

pchaigno commented Apr 17, 2018

munificent commented Apr 23, 2018

pchaigno commented Aug 4, 2018

Add Wren language #4088

Add Wren language #4088

Conversation

bates64 commented Apr 3, 2018 • edited Loading

Checklist:

lildude left a comment

Choose a reason for hiding this comment

lildude Apr 6, 2018

Choose a reason for hiding this comment

munificent Apr 6, 2018

Choose a reason for hiding this comment

lildude Apr 6, 2018

Choose a reason for hiding this comment

bates64 commented Apr 7, 2018 • edited Loading

bates64 commented Apr 7, 2018 • edited Loading

lildude commented Apr 12, 2018

Alhadis commented Apr 12, 2018

lildude commented Apr 12, 2018

bates64 commented Apr 13, 2018

Alhadis commented Apr 13, 2018 • edited Loading

munificent commented Apr 16, 2018

lildude commented Apr 17, 2018

pchaigno commented Apr 17, 2018

munificent commented Apr 23, 2018

pchaigno commented Aug 4, 2018

bates64 commented Apr 3, 2018 •

edited

Loading

bates64 commented Apr 7, 2018 •

edited

Loading

bates64 commented Apr 7, 2018 •

edited

Loading

Alhadis commented Apr 13, 2018 •

edited

Loading