Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace haxe-sublime-bundle with haxe-TmLanguage #4079

Merged
merged 4 commits into from
Apr 6, 2018
Merged

Replace haxe-sublime-bundle with haxe-TmLanguage #4079

merged 4 commits into from
Apr 6, 2018

Conversation

Gama11
Copy link
Contributor

@Gama11 Gama11 commented Mar 27, 2018

Description

This replaces the Haxe grammar from haxe-sublime-bundle, which hasn't been updated in a few years and not kept up with new Haxe 4 syntax as result, with haxe-TmLanguage. The grammar is based on the one from haxe-sublime-bundle, but includes a large number of fixes and enhancements. It's also used for the Haxe VSCode extension.

To demonstrate the differences, I've picked out a few of haxe-TmLanguage's test cases for the lightshow comparison below.

Checklist:

  • I am changing the source of a syntax highlighting grammar

@Gama11
Copy link
Contributor Author

Gama11 commented Mar 27, 2018

It seems Travis is failing for reasons unrelated to my changes?

@lildude
Copy link
Member

lildude commented Mar 28, 2018

It seems Travis is failing for reasons unrelated to my changes?

Yup. Looks like a problem building the rugged gem for some reason. Looking into it.

@lildude
Copy link
Member

lildude commented Mar 28, 2018

CI should pass once #4081 has been merged.

@Gama11
Copy link
Contributor Author

Gama11 commented Mar 29, 2018

Ok, CI is passing now. :)

@lildude
Copy link
Member

lildude commented Apr 6, 2018

I can't see any problems with this, but will leave it to @pchaigno or @Alhadis to double-check me before I give my final 👍

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even without any knowledge of Haxe, the improvements to highlighting are immediately visible. LGTM. 👍

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better to me too. Thanks for the contribution and welcome to Linguist.

@lildude lildude merged commit 34c623e into github-linguist:master Apr 6, 2018
@Gama11 Gama11 deleted the haxe branch April 6, 2018 16:27
@Gama11 Gama11 mentioned this pull request Apr 7, 2018
5 tasks
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants