-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace haxe-sublime-bundle with haxe-TmLanguage #4079
Conversation
It seems Travis is failing for reasons unrelated to my changes? |
Yup. Looks like a problem building the rugged gem for some reason. Looking into it. |
CI should pass once #4081 has been merged. |
Ok, CI is passing now. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even without any knowledge of Haxe, the improvements to highlighting are immediately visible. LGTM. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better to me too. Thanks for the contribution and welcome to Linguist.
Description
This replaces the Haxe grammar from haxe-sublime-bundle, which hasn't been updated in a few years and not kept up with new Haxe 4 syntax as result, with haxe-TmLanguage. The grammar is based on the one from haxe-sublime-bundle, but includes a large number of fixes and enhancements. It's also used for the Haxe VSCode extension.
To demonstrate the differences, I've picked out a few of haxe-TmLanguage's test cases for the lightshow comparison below.
Checklist: