Additions to the Perl family of languages #4066

JJ · 2018-03-13T07:00:21Z

Adding some extensions and sample files for Perl

Description

Moves Rexfile to the correct language
Adds extensions to Perl and Perl6. Some sample files, too.

Checklist:

I am associating a language with a new file extension. (but search for pod6 does not seem to work very well)
- I have included a real-world usage sample for all extensions added in this PR:
  - Sample source(s):
    - https://github.com/perl6/doc/blob/master/doc/Type/Any.pod6
  - Sample license(s): ARTISTIC https://github.com/perl6/doc/blob/master/LICENSE
- I have included a change to the heuristics to distinguish my language from others using the same extension.

And also adding a little bit of text to the README file to help with local use and test.

Refs github-linguist#2309 and also changes github.com to an uniform capitalization.

@pchaigno

Initial suggestion by @pchaigno, slightly changed to eliminate false positives such as "classes" or "modules" at the beginning of a line in the =pod BTW, it would be interesting to just eliminate these areas for language detection.

And adds .pod6

I just found I had this sitting here, so I might as well follow instructions to fix it.

Alhadis · 2018-03-13T08:03:48Z

lib/linguist/languages.yml

@@ -3369,6 +3369,8 @@ Perl:
  - ".psgi"
  - ".t"
  filenames:
+  - Makefile.PL


This is redundant, because it'll be matched against the *.pl file extension.

@Alhadis That extension is shared between Perl, Perl 6, and Prolog. Adding the Makefile.PL might improve detection for that particular case. Are we sure Makefile.PL is always Perl and not Perl 6 though?

I stand corrected, then. 😉 @pchaigno knows more about the Bayesian classifier than I do.

I don't recall ever seeing a Perl 6 version of Makefile.PL... it's always ever been used by Perl 5 modules downloaded/installed from CPAN. I could be wrong though.

Pretty sure. Perl6 has pretty much normalized to .pl6 or .p6 now. It's not using this particular file, either. This is the repo for all modules https://github.com/moritz/perl6-all-modules/search?utf8=%E2%9C%93&q=%22Makefile.PL%22&type= and it's not there even once. Makefile.PL is kind of a Rakefile used for some CPAN distributions; Perl6 uses zef and META6.json

@pchaigno knows more about the Bayesian classifier than I do.

I don't know much about the classifier either, but in this particular case, there's a specific filename strategy before we reach the classifier.

PS: Not sure why I keep using "particular case" today...

Ping... Is there anything missing?

No, it looks fine to me. For the sake of quicker review, it might be better to omit .pod6 since #3366 is more appropriate for discussion its inclusion.

The problem there is that it might need a bit (or a lot) of work. If you want, you can close that one and I'll redo this one, and then that one...

Eliminated .pod6. I can try and work on that one, although I can't add or modify that pull request...

Don't worry about #3366. :) I believe that PR needs formal approval from GitHub staff more than anything.

Alhadis · 2018-03-13T08:32:25Z

CONTRIBUTING.md

@@ -6,11 +6,15 @@ Contributions to this project are [released](https://help.github.com/articles/gi

 This project adheres to the [Contributor Covenant Code of Conduct](http://contributor-covenant.org/). By participating, you are expected to uphold this code.

-The majority of contributions won't need to touch any Ruby code at all.


I see you first forked Linguist in November 2015 (!!). You're overwriting unrelated changes that have been made to the docs since then. Please update CONTRIBUTING.md with the latest version.

@JJ You might want to update your fork...

I'll do that 👍

I've restored the HEAD copy. In fact, advice to install CMAKE, which was the only actual change, is already in the README.md file.

Alhadis · 2018-03-13T08:34:20Z

lib/linguist/languages.yml

@@ -3369,6 +3369,8 @@ Perl:
  - ".psgi"
  - ".t"
  filenames:
+  - Makefile.PL
+  - Rexfile


In-the-wild usage is a little questionable... only ~155 results, although they appear to be well-distributed across users/repositories (which technically meets the criteria of "being used in hundreds of repositories"). I think it's okay, particularly since it's an uncommon filename unlikely to cause conflict. @pchaigno, thoughts?

I'll defer to @lildude 😄

Problem here is that Rexfile was actually in the Perl6 field (my fault: https://github.com/github/linguist/pull/2005/files). It should better be here, Rexfile is in no way Perl6 code.

This is fine. It slipped under the radar before when it was initially added so no point removing it now.

Alhadis · 2018-03-13T08:35:11Z

lib/linguist/languages.yml

@@ -3387,9 +3389,8 @@ Perl 6:
  - ".pl6"
  - ".pm"
  - ".pm6"
+  - ".pod6"


This was discussed before, and should be omitted. See #3366.

Checking it out... And I would kindly ask you to reconsider. What brought me (back) here was github/markup#1173, where I spent quite a long time until I discovered .pod6 files were not recognized as Perl6, which had me do a workaround... In fact, I fear .pod6 files will not be recognized as such, even by markup, if that extension is not included here. pod6 is used extensively in https://github.com/perl6/doc, if nowhere else, and as indicated in #3366, it would help adoption of the language. I can wait for that one to be accepted, though... Or just eliminate that change and defer to that one.

Personally, I'm okay with adding .pod6 as an extension. But since there's been no official consensus on the matter, it might be easier to omit this particular addition and defer to #3366 instead. =)

I see installation of cmake is advised in README.md

My mistake, never mind.

To leave way for github-linguist#3366 or succeeding PRs.

JJ · 2018-03-28T11:08:34Z

Thanks! (But let me worry about that one, it's really important for the community)

lildude

Just a little clean up and we should be good to go.

lildude · 2018-03-28T15:53:42Z

samples/Perl 6/Any.pod6

@@ -0,0 +1,987 @@
+=begin pod


This file needs to be removed too as you've removed .pod6 from this PR.

JJ · 2018-03-28T16:28:44Z

OK.

lildude · 2018-04-06T16:01:09Z

Pulling in the latest master into your fork will address the CI failure. You'll also need to address the merge conflict.

JJ · 2018-04-06T17:28:34Z

Will do that. Thanks.

JJ · 2018-04-07T08:57:46Z

Please check the latest change that addresses conflict.

JJ · 2018-04-07T09:07:37Z

Fixes CI error about alphabetical order on the files.

JJ · 2018-04-09T14:50:57Z

Sorry, what else is left to do here?

Alhadis · 2018-04-09T15:15:27Z

Sorry, what else is left to do here?

Wait for this long-ass harvest to finish over my primitive, non-NBN-enabled Australian Internet connection, and be patient.

As an alternative to patience, you could entertain yourself by racing it against the following Perl script and seeing which one finishes in your lifetime:

$_ = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
/a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*a*[nope]/;

(For anybody reading this who isn't familiar with catastrophic backtracking, the command above will kill your computer)

JJ · 2018-04-09T15:18:03Z

I can do that in Perl 6, where infinity is just another data structure... Or I can wait for the latest CI to finish with flying colors, which it did! 🐧

Alhadis · 2018-04-09T15:30:13Z

Better idea! Let's all figure out why negative zero exists, and what sick human being thought a zero needed a sign-bit, and wonder why the hell -0 is different to 0 in any fathomable universe.

We can't divide by zero, but we can pointlessly sign it as +0 or -0 instead. Mmmm'kay, IEEE 754, whatever you reckon...

I don't know why I'm flagellating myself thinking about the real-world difference of positive and negative zero when I should be making wisecracks in commit logs like last night.

lildude · 2018-04-11T14:25:13Z

samples/Perl 6/chromosome.pl

+
+my $len = 32;
+my $this-chromosome = Chromosome.new( chromosome => map( { rand >= 0.5 ?? True !! False }, 1..$len )  );
+say $this-chromosome.chromosome();


Is this file somehow uniquely Perl 6 such that it can clearly be differentiated from the exact same code written in Perl 5, or should this be added to the samples/Perl/?

The reason I ask is we use these samples to train the classifier and if this is identical to Perl 5, it's likely to add noise to the Perl 6 side of the classifier when it comes down to a Perl 5 vs Perl 6 comparison.

It could also go into tests/fixtures/Perl 6/ if we don't want it as a sample.

On a superficial level, it could look similar to Perl. It's been a long time, but if I remember correctly I included it here precisely for that reason. It could go to fixtures alright. Just let me know what to do, and I'll do it straight away.

Ok. If this is just to keep the tests passing, then yup, tests/fixtures/Perl 6/ is definitely the best place for it.

Done. I'm getting some local errors which apparently have nothing to do with moving stuff around. Let me know if there's something I can do about that.

lildude

LGTM. Thanks for taking on our feedback so graceously @JJ.

Feel free to open an issue if you need any help sorting out the local errors you mentioned.

JJ · 2018-04-11T15:34:34Z

Yay! You made my day. Thanks!

JJ added 17 commits October 31, 2015 19:35

Mainly fixing problems with Perl heuristics

1732850

And also adding a little bit of text to the README file to help with local use and test.

Adds new sample

9d57d6f

Adds a couple of samples more, not represented before

13d5ebd

Moves installation intructions to CONTRIBUTING.md

d3cf280

Refs github-linguist#2309 and also changes github.com to an uniform capitalization.

Correcting error. Great job, CI

f437f0c

Moving another file

2d8cd85

Merge branch 'master' of github.com:github/linguist

3466074

Adds samples and new checks for perl/perl6

f46e876

Stupid mistake

ff4f40a

Changing regex for perl5 vs perl6

c1796bc

Initial suggestion by @pchaigno, slightly changed to eliminate false positives such as "classes" or "modules" at the beginning of a line in the =pod BTW, it would be interesting to just eliminate these areas for language detection.

Adds extensions to Perl

f1491a6

Eliminates Rexfile from Perl6

22bd264

And adds .pod6

Followup to github-linguist#2709

0dca075

I just found I had this sitting here, so I might as well follow instructions to fix it.

Adds example for pod6

a3aed35

Eliminates .pod because it's its own language

2d85463

Removes bad directory

cc2e8a7

Reverting changes that were already there

4eaa4b3

Alhadis previously requested changes Mar 13, 2018

View reviewed changes

Restored CONTRIBUTING.md from head

5601865

I see installation of cmake is advised in README.md

Alhadis mentioned this pull request Mar 13, 2018

Register "cperl" as an alias of Perl 5 #4067

Merged

JJ added 2 commits March 28, 2018 12:26

Eliminates .pod6

6ce294d

To leave way for github-linguist#3366 or succeeding PRs.

Merge branch 'master' of github.com:JJ/linguist

072e774

Alhadis approved these changes Mar 28, 2018

View reviewed changes

lildude requested changes Mar 28, 2018

View reviewed changes

JJ added 2 commits March 28, 2018 18:29

Merge branch 'master' of github.com:github/linguist

648e8cb

Removed by request, since we're no longer adding this extension

0bd8636

JJ mentioned this pull request Mar 29, 2018

Add Pod 6 to the languages.yml #4083

Merged

4 tasks

Solves conflict

a33ad3e

Sorting by alphabetical order filenames

9dd0975

JJ mentioned this pull request Apr 9, 2018

Add .pod6 filetype to Perl6 #3366

Closed

JJ added 2 commits April 9, 2018 17:01

Puts things in the required order

5f74ba4

Fixes another conflict

52b5b91

lildude reviewed Apr 11, 2018

View reviewed changes

JJ added 2 commits April 11, 2018 17:00

Merge branch 'master' of github.com:github/linguist

2b46d79

Moved from sample to test fixtures

679bb4c

lildude approved these changes Apr 11, 2018

View reviewed changes

lildude merged commit a9ff59a into github-linguist:master Apr 11, 2018

github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024

		@@ -6,11 +6,15 @@ Contributions to this project are [released](https://help.github.com/articles/gi

		This project adheres to the [Contributor Covenant Code of Conduct](http://contributor-covenant.org/). By participating, you are expected to uphold this code.

		The majority of contributions won't need to touch any Ruby code at all.

@@ @@ -3387,9 +3389,8 @@ Perl 6: @@
                 - ".pl6"
                 - ".pm"
                 - ".pm6"
+                - ".pod6"

Additions to the Perl family of languages #4066

Additions to the Perl family of languages #4066

Conversation

JJ commented Mar 13, 2018 • edited Loading

Description

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JJ commented Mar 28, 2018 via email

lildude left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JJ commented Mar 28, 2018 via email

lildude commented Apr 6, 2018

JJ commented Apr 6, 2018 via email

JJ commented Apr 7, 2018

JJ commented Apr 7, 2018

JJ commented Apr 9, 2018

Alhadis commented Apr 9, 2018 • edited Loading

JJ commented Apr 9, 2018

Alhadis commented Apr 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lildude left a comment • edited Loading

Choose a reason for hiding this comment

JJ commented Apr 11, 2018

JJ commented Mar 13, 2018 •

edited

Loading

Alhadis commented Apr 9, 2018 •

edited

Loading

lildude left a comment •

edited

Loading