Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax for SARL language. #3772

Closed

Conversation

gallandarakhneorg
Copy link

SARL language: http://www.sarl.io

Signed-off-by: Stéphane Galland [email protected]

Signed-off-by: Stéphane Galland <[email protected]>
@pchaigno
Copy link
Contributor

Please have a look at the guidelines to add support for a new language to Linguist. In particular, we'll need some evidence of in-the-wild usage across github.com.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to @pchaigno's comment, and in prep for when SARL becomes more popular, this PR is missing a license for the new grammar as it has not been added using the script detailed at https://github.com/github/linguist/blob/master/CONTRIBUTING.md#adding-a-language

We'd also need to know the source and license of the samples.

@gallandarakhneorg
Copy link
Author

The grammar and the samples are under Apache 2 License. The submodule included into this PR contains the license file: https://github.com/sarl/sarl-textmate/blob/master/LICENSE. The grammar license is also specified into the grammar file: https://github.com/sarl/sarl-textmate/blob/master/sarl.tmLanguage

Regarding the sample code, I have not put the license into the sample to mimic the samples of the other languages. The source of the sample is: https://github.com/sarl/sarl/tree/master/contribs/io.sarl.examples/io.sarl.examples.plugin/projects

Should I add some LICENSE file or comment to each of the sample files?

@gallandarakhneorg
Copy link
Author

According to the provided guidelines, please find below the link to the Github search result:
https://github.com/search?q=io.sarl.lang.core&type=Code

@lildude
Copy link
Member

lildude commented Oct 5, 2017

Thanks for the clarification of the license for the samples @gallandarakhneorg. That's all we need for them.

However, there are a few other issues still outstanding:

  1. It looks like your new grammar wasn't added using the script/add-language script as the grammar license hasn't been included in this PR.
  2. You're adding SARL with the extension .sarl which doesn't return many unique hits, hence @pchaigno and my previous comments about it. Your sample search is referencing many many other file types and languages and not specifically SARL. Limiting your search to just the .sarl extension returns even fewer hits.
  3. There's a conflict with .gitmodules - you need up merge github/linguist's master into your fork.
  4. There are still a few failing tests that need addressing - the errors in the tests should help you identify the problems and make the necessary fixes.

@pchaigno
Copy link
Contributor

pchaigno commented Aug 4, 2018

Closing in favor of #4219. We'll monitor the popularity of the extension there.

If you have an improved search query compared to the one used in #4219, please post it here and I'll update #4219.

@pchaigno pchaigno closed this Aug 4, 2018
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants