Fix ambiguous classification test

[tgjones]

Found while preparing #3490.

This change means that the test does now find some ambiguous languages, and tests that the relevant samples resolve to the correct language, but it fails with this assertion:

  1) Failure:
TestClassifier#test_classify_ambiguous_languages [/Users/timjones/Code/github/linguist/test/test_classifier.rb:53]:
/Users/timjones/Code/github/linguist/samples/Makefile/filenames/Makefile.frag
[["JavaScript", -3411.2346496412188], ["GLSL", -3498.798416469136]].
Expected: "Makefile"
  Actual: "JavaScript"

Presumably this is because there are some filename overrides, including for Makefile, that aren't picked up if we use Language.find_by_extension. Any suggestions for fixing this?

[tgjones]

Bump - any thoughts on my question above?

[lildude]

Presumably this is because there are some filename overrides, including for Makefile, that aren't picked up if we use Language.find_by_extension. Any suggestions for fixing this?

Sorry about the delay here. Yup, this is it. Makefile.frag is an explicitly called out filename for Makefiles so shouldn't need classification by extension, hence the failure.

We need to do both filename and extension as shown in #3709 (which reminded me that I'd seen this before which brought me here).

I'll leave it to you and @smola to determine who is going to ultimately fix this, or you can race for it 😁

[lildude]

Closing as this issue has now been fixed with #3709