Removed Jade from html group #2978
Conversation
Jade should not be included under html because it serves a very different purpose, while it does compile to html it doesn't look like html and is a language for templating rather than just markup. Fixes #2977
|
Hi @zacps, thanks for opening this PR. While I believe I understand your motivations for making this change, we've chosen to implement language groups in Linguist as we believe they represent higher-level logical groupings for collections of languages. For example the
Quoting from http://jade-lang.com/reference/
Which I think makes Jade a good candidate for the
This argument can be made for pretty much every example in the list above too. My question to you is: is there a usability problem that you're facing here? One thing I do think needs fixing on GitHub is what happens if you click the language bar for a repository and view the search results. Currently, clicking the language bar on https://github.com/zacps/go-wiki shows you that a bunch of the files are in
you get sent to this page:
which I think is pretty confusing for all. My suggested fix is that we work out how to link these groups properly to the languages in the group (in this case we would show the The alternative is that we simply remove the groups from Linguist but I think they serve a useful purpose right now. |
|
Yeah that's a fair point, I can't say I would know how to change that behaviour though. I guess wherever the handler for the bar is it's looking at the group name rather than the name itself. |
|
There are languages like CoffeeScript/LiveScript, which are shown separately from JavaScript. |
Jade should not be included under html because it serves a very different purpose, while it does compile to html it doesn't look like html and is a language for templating rather than just markup.
Fixes #2977