Skip to content

Commit

Permalink
Ruby 1.9 compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
@aroben
aroben committed Dec 22, 2014
1 parent a7153f1 commit fca8232
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/test_grammars.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_submodules_are_in_sync

def test_local_scopes_are_in_sync
actual = YAML.load(`"#{File.join(ROOT, "script", "convert-grammars")}" --output - --no-install --no-remote 2>/dev/null`)
assert_predicate $?, :success?
assert $?.success?, "script/convert-grammars failed"

# We're not checking remote grammars. That can take a long time and make CI
# flaky if network conditions are poor.
Expand Down

3 comments on commit fca8232

@aroben
Copy link
Contributor Author

@aroben aroben commented on fca8232 Dec 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still care about Ruby 1.9? We run it in Travis, but do we actually need to maintain compatibility?

@arfon
Copy link
Contributor

@arfon arfon commented on fca8232 Dec 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour of dropping 1.9 - it would allow me to close this 😉 #353

@arfon
Copy link
Contributor

@arfon arfon commented on fca8232 Jan 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aroben - I just closed #353 as a wont-fix. Perhaps we should move forward and drop 1.9 support?

Please sign in to comment.