Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added variables in the root module to allow passing in pre and … #45

Conversation

jaydenrasmussen
Copy link
Contributor

@jaydenrasmussen jaydenrasmussen commented Jun 29, 2020

Requirements for Adding, Changing, or Removing a Feature

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must contribute a change that has been endorsed by the maintainer team. See details in the template below.
  • The pull request must update the test suite to exercise the updated functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution.

Issue Endorsed by Maintainers

Description of the Change

Added two variables to the root module userdata_preinstall and userdata_postinstall which will allow end-users to pass in extraneous scripts to their runners to install dependencies, and other software needed for their GitHub Actions workflows.

Alternate Designs

The variables were already present in the runners module, just not consumed by the root module. This has been updated to allow it to be passed down to that module. There isn't really an alternative to this pattern in terraform.

Possible Drawbacks

Yet another variable to add into the module (more documentation).

Verification Process

Verified by deploying with Terraform into a shared environment for actions runners.

Release Notes

  • Allows userdata to be passed into the instance before and after the GitHub Actions Runner is installed.

@npalm npalm self-requested a review June 30, 2020 06:42
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaydenrasmussen thanks for catching those missing paramters. I have update the readme. We use pre-commit to auto update the readme. But seems missing in the instruction.

@npalm npalm merged commit 1d18097 into github-aws-runners:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants