Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow operator to pass in a list of managed IAM policy ARNs for the runner role #361

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Allow operator to pass in a list of managed IAM policy ARNs for the runner role #361

merged 2 commits into from
Dec 1, 2020

Conversation

jpalomaki
Copy link
Contributor

@jpalomaki jpalomaki commented Nov 28, 2020

For https://github.com/philips-labs/terraform-aws-github-runner/issues/308. Policies can be managed outside of this stack, or within this stack like so:

resource "aws_iam_policy" "my_policy" {
  ...
}

module "runners" {
  ...
  runner_iam_role_managed_policy_arns = [
    aws_iam_policy.my_policy.arn,
  ]
}

Tested by running a plan on an existing stack, with and without the list of managed policies.

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpalomaki thanks looks all good

@npalm
Copy link
Member

npalm commented Dec 1, 2020

fix #308

@npalm npalm merged commit cfc7e8c into github-aws-runners:develop Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants