Added Network Interface Configuration to Runners Module #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please can you rebase your work, last week two other PR's enabling public IP addresses are merged. See #3547 |
|
Hi, I have checked the new contributions and I see that the changes have already been merged, therefore considering that the modifications are no longer necessary I am closing the pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an option to associate a public IP address with the EC2 instance created for the GitHub runner.
The modification includes an additional variable associate_public_ip_address in the variables.tf file and references this variable in the main.tf file under the network_interfaces block for the EC2 instance configuration within the runners module.
Additionally, documentation has been updated in the README.md of the runners module to explain the new configuration option.
This change allows for better flexibility when deploying runners in different network environments. In scenarios where a public IP is not required or preferred due to security or cost considerations, this option can now be toggled off.