fix: Honor runner boot time when topping up pools #2590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Remove support check_run * format, lint
fix: Remove old cleanup mechanism (< 0.19.0)
* feat: Remove support check_run (#2521) * chore: Remove support check_run * format, lint * feat: Remove old scale down mechanism (< 0.19.0) (#2519) fix: Remove old cleanup mechanism (< 0.19.0) * feat: added changes for multi runner. * fix: region. * fix: more fixes. * tuple to list. * fixes. * fixes. * fixes. * fixes. * fixes. * fixes. * fix: formatting. * fix: formatting. * fix: formatting. * fix: moved some blocks outside runner config. * fix: few more updates * fix: liniting. * fix: updated example output * changed runner group name. * fix: updated the tests. * fix: addressed review comments. * fix: linting issues. * fix: formatting. * fix: updated tf version. * fix: Remove removed prerelease option * Add ubuntu runner to example * refactor: use each instead of count * fix: few small issues. * refactor: syncer to count for multi runner * fix: comments. * fix: added Readme. * fix: errors. * move variable to runner config * fix: updated the readme. * Add todos * feat: added windows runner configuration, completed todos and added the weight for runner config matchers. * chore: Update docs * fix: reverted tf versions. * fix: addressed comments. * fix: missed. * fix: formatting. * Update terraform versions in CI * Update terraform versions in CI * Update docs * fix: coverage. * Update docs * improve test coverage webhook * Apply suggestions from code review * fix: formatting. * fix: fixed merge issues. * fix: syntax. Co-authored-by: Niek Palm <[email protected]> Co-authored-by: Niek Palm <[email protected]> Co-authored-by: navdeepg2021 <[email protected]>
## [2.0.0-next.1](philips-labs/terraform-aws-github-runner@v1.12.0...v2.0.0-next.1) (2022-10-19) ### ⚠ BREAKING CHANGES * **ci:** ### Features * Add multi-runner capability ([#2472](https://github.com/philips-labs/terraform-aws-github-runner/issues/2472)) ([c08b335](philips-labs/terraform-aws-github-runner@c08b335)), closes [#2521](https://github.com/philips-labs/terraform-aws-github-runner/issues/2521) [#2519](https://github.com/philips-labs/terraform-aws-github-runner/issues/2519) * Experimental feature - Duplicate workflow job event to extra queue ([#2268](https://github.com/philips-labs/terraform-aws-github-runner/issues/2268)) ([ac046b8](philips-labs/terraform-aws-github-runner@ac046b8)) * Remove old scale down mechanism (< 0.19.0) ([#2519](https://github.com/philips-labs/terraform-aws-github-runner/issues/2519)) ([721d7c3](philips-labs/terraform-aws-github-runner@721d7c3)) * Remove support check_run ([#2521](https://github.com/philips-labs/terraform-aws-github-runner/issues/2521)) ([272a293](philips-labs/terraform-aws-github-runner@272a293)) ### Miscellaneous Chores * **ci:** Enable ci for next branch ([48769ca](philips-labs/terraform-aws-github-runner@48769ca)), closes [#2472](https://github.com/philips-labs/terraform-aws-github-runner/issues/2472) [#2517](https://github.com/philips-labs/terraform-aws-github-runner/issues/2517) [#2521](https://github.com/philips-labs/terraform-aws-github-runner/issues/2521) [#2517](https://github.com/philips-labs/terraform-aws-github-runner/issues/2517) [#2519](https://github.com/philips-labs/terraform-aws-github-runner/issues/2519) [#2517](https://github.com/philips-labs/terraform-aws-github-runner/issues/2517)
|
@npalm This seems to be working for us so far. There's still some occasional odd scaling behavior that we haven't pinned down, though it generally seems to be due to misconfiguration/understandings of how pools/ephemeral runners interact, but this specific change has fixed the primary cause of over-scaling that we've seen. Not sure if you'd like me to update the conflicts or remove the draft status, but if so let me know |
|
Thanks for the update, will try to check the PR tomorrow. |
|
Seems something went wrong with rebasing. Please can you chck? I assume the intention is merging back into develop. Seems you rebased to next. |
npalm
force-pushed
the
next
branch
2 times, most recently
from
e03d903 to
c724f32
Compare
npalm
force-pushed
the
next
branch
2 times, most recently
from
083e881 to
8218c2a
Compare
mckern
referenced
this pull request
in segmentio/terraform-aws-github-runner
Dec 7, 2022
Rebased off of the patch provided by Michael Poutre <[email protected]> in philips-labs/terraform-aws-github-runner#2590 and re-targeted against the develop branch. Co-authored-by: Ryan McKern <[email protected]>
npalm
force-pushed
the
next
branch
2 times, most recently
from
2c87ee9 to
24c19b7
Compare
npalm
referenced
this pull request
Dec 28, 2022
Rebased off of the patch provided by Michael Poutre <[email protected]> in philips-labs/terraform-aws-github-runner#2590 and re-targeted against the develop branch. Co-authored-by: Ryan McKern <[email protected]>
npalm
force-pushed
the
next
branch
4 times, most recently
from
1022cb6 to
5919612
Compare
npalm
referenced
this pull request
Jan 11, 2023
Rebased off of the patch provided by Michael Poutre <[email protected]> in philips-labs/terraform-aws-github-runner#2590 and re-targeted against the develop branch. Co-authored-by: Ryan McKern <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2449
This change updates the pool lambda so that instances aren't ignored while they boot