Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewed the documentation and lambdas #1035

Merged
merged 41 commits into from
Aug 11, 2021
Merged
Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
66bd078
chore: Bump aws-sdk (#752) (#909)
dependabot[bot] Jun 18, 2021
77c8e13
chore: Bump aws-sdk (#752) (#908)
dependabot[bot] Jun 18, 2021
fe0a126
chore: Bump aws-sdk (#752) (#887)
dependabot[bot] Jun 18, 2021
174b4ca
chore: Bump aws-sdk (#752) (#885)
dependabot[bot] Jun 18, 2021
0f1493f
chore: Bump aws-sdk (#752) (#889)
dependabot[bot] Jun 18, 2021
5314469
chore: Bump aws-sdk (#752) (#892)
dependabot[bot] Jun 18, 2021
640ef5f
chore: Bump aws-sdk (#752) (#907)
dependabot[bot] Jun 18, 2021
1658635
chore: Bump aws-sdk (#752) (#864)
dependabot[bot] Jun 18, 2021
a401c0d
chore: Bump eslint in /modules/webhook/lambdas/webhook (#918)
dependabot[bot] Jun 24, 2021
870280b
chore: Bump typescript (#929)
dependabot[bot] Jun 24, 2021
0fdf8cf
chore: Bump @typescript-eslint/eslint-plugin (#928)
dependabot[bot] Jun 24, 2021
a6b9a29
chore: Bump typescript in /modules/webhook/lambdas/webhook (#926)
dependabot[bot] Jun 24, 2021
b5096bb
feat: Added support for white listing of repositories (#915)
ravenolf Jul 7, 2021
97ef7fb
chore(examples): Upgrade default example to terraform 1.x.x
npalm Jul 14, 2021
11a6f57
chore(doc): Remove org level admin permission #801
npalm Jul 14, 2021
68635dd
feat: make delay of webhook event configurable (#990)
npalm Jul 15, 2021
6278c17
fix: change module exports and upgrade vercel to latest release (#1005)
PatrickMennen Jul 26, 2021
d5611b0
fix: reduce permission required for session manager (#1018)
npalm Jul 28, 2021
fb3fd99
Merge branch 'develop' of https://github.com/philips-labs/terraform-a…
aadrijnberg Aug 3, 2021
e15ec0c
Merge branch 'philips-labs-develop' into develop
aadrijnberg Aug 3, 2021
86e7912
feat: Store lambda secrets paramaters in Paramater Store (#941)
mcaulifn Aug 4, 2021
0896a15
feat: Adding support for new workflow_job event. (#1019)
npalm Aug 5, 2021
8b6a392
chore: Bump @types/node in /modules/webhook/lambdas/webhook
dependabot[bot] Aug 5, 2021
c23e0ed
chore: Bump tar from 4.4.13 to 4.4.15 in /.release
dependabot[bot] Aug 5, 2021
d467c90
chore: Bump jest-mock-extended in /modules/runners/lambdas/runners
dependabot[bot] Aug 5, 2021
3c87a68
chore: Bump @types/node
dependabot[bot] Aug 5, 2021
5b64c6b
Merge branch 'develop' of github.com:philips-labs/terraform-aws-githu…
aadrijnberg Aug 5, 2021
4f1a25e
fix: handle situation of no prereleases correctly, and propagate lamb…
aadrijnberg Jul 18, 2021
833724e
chore (doc): small improvements
aadrijnberg Jul 18, 2021
791b8a3
fix: wait for scaleDown to have finished before calling callback
aadrijnberg Jul 18, 2021
18b2b45
chore: code consistency and improvements
aadrijnberg Jul 18, 2021
a5ba472
fix: tests were not always correct or incomplete or duplicate
aadrijnberg Jul 18, 2021
6c0b11a
fix: use consistent reporting back to caller
aadrijnberg Jul 18, 2021
aae4735
chore(release): 0.15.1 [skip ci]
semantic-release-bot Jul 13, 2021
f1b3f47
Update CHANGELOG
aadrijnberg Aug 3, 2021
cf6b198
fix: CONTRIBUTION.md should refer develop iso master branch
aadrijnberg Aug 3, 2021
0f52a77
Cleanup
aadrijnberg Aug 5, 2021
cc92fa4
Incorporate review comments and fix build issue
aadrijnberg Aug 6, 2021
2586abe
Merge branch 'develop' of github.com:philips-labs/terraform-aws-githu…
aadrijnberg Aug 6, 2021
ce1afb8
Merge branch 'develop' into my-fixes
aadrijnberg Aug 6, 2021
acae897
Update modules/runners/README.md
aadrijnberg Aug 10, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ secrets.auto.tfvars
*.zip
*.gz
*.tgz
*.env
*.env*
.vscode

**/coverage/*
6 changes: 3 additions & 3 deletions .release/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4282,9 +4282,9 @@ supports-hyperlinks@^2.1.0:
supports-color "^7.0.0"

tar@^4.4.10, tar@^4.4.12, tar@^4.4.13:
version "4.4.13"
resolved "https://registry.yarnpkg.com/tar/-/tar-4.4.13.tgz#43b364bc52888d555298637b10d60790254ab525"
integrity sha512-w2VwSrBoHa5BsSyH+KxEqeQBAllHhccyMFVHtGtdMpF4W7IRWfZjFiQceJPChOeTsSDVUpER2T8FA93pr0L+QA==
version "4.4.15"
resolved "https://registry.yarnpkg.com/tar/-/tar-4.4.15.tgz#3caced4f39ebd46ddda4d6203d48493a919697f8"
integrity sha512-ItbufpujXkry7bHH9NpQyTXPbJ72iTlXgkBAYsAjDXk3Ds8t/3NfO5P4xZGy7u+sYuQUbimgzswX4uQIEeNVOA==
dependencies:
chownr "^1.1.1"
fs-minipass "^1.2.5"
Expand Down
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# Changelog

## Unreleased
npalm marked this conversation as resolved.
Show resolved Hide resolved

### Bug fixes

* Use consistent reporting back to caller in the Webhook lambda
* In runners lambda wait for scaleDown to have finished before calling callback
* In runner-binary-syncer support a runner binary having releases but no prereleases
* When the runner-binary-syncer encounters an error report that back up to the lambda.ts so that it can report that back to the caller.
* Fix incorrect or incomplete tests, and remove duplicate tests
* Fix CONTRIBUTION.md, as the user should base on the develop branch instead of the master branch

### [0.15.1](https://github.com/philips-labs/terraform-aws-github-runner/compare/v0.15.0...v0.15.1) (2021-07-13)


### Bug Fixes

* apply patch for broken scale up lambda [#980](https://github.com/philips-labs/terraform-aws-github-runner/issues/980) ([b957e26](https://github.com/philips-labs/terraform-aws-github-runner/commit/b957e263b6dbc3d299eab3236b479b9113b1fecb))

## [0.15.0](https://github.com/philips-labs/terraform-aws-github-runner/compare/v0.14.0...v0.15.0) (2021-07-07)


Expand Down
35 changes: 18 additions & 17 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

We'd love for you to contribute to our source code and to make the Forest even better than it is today! Here are the guidelines we'd like you to follow:

- [Question or Problem?](#question)
- [Issues and Bugs](#issue)
- [Feature Requests](#feature)
- [Submission Guidelines](#submit)
- [Further Info](#info)
* [Question or Problem?](#question)
* [Issues and Bugs](#issue)
* [Feature Requests](#feature)
* [Submission Guidelines](#submit)
* [Further Info](#info)

## <a name="question"></a> Got a Question or Problem?

Expand All @@ -27,7 +27,6 @@ You can request a new feature by submitting an issue to our [Github Repository][
* **Major Changes** that you wish to contribute to the project should be discussed first on our [Slack group][slack] so that we can better coordinate our efforts, prevent duplication of work, and help you to craft the change so that it is successfully accepted into the project.
* **Small Changes** can be crafted and submitted to the [Github Repository][github] as a Pull Request.


## <a name="docs"></a> Want a Doc Fix?

If you want to help improve the docs, it's a good idea to let others know what you're working on to minimize duplication of effort. Create a new issue (or comment on a related existing one) to let others know what you're working on.
Expand All @@ -37,6 +36,7 @@ For large fixes, please build and test the documentation before submitting the M
## <a name="submit"></a> Submission Guidelines

### Submitting an Issue

Before you submit your issue search the archive, maybe your question was already answered.

If your issue appears to be a bug, and hasn't been reported, open a new issue. Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues. Providing the following information will increase the chances of your issue being dealt with quickly:
Expand All @@ -58,7 +58,7 @@ Before you submit your merge request consider the following guidelines:
* Make your changes in a new git branch:

```shell
git checkout -b my-fix-branch master
git checkout -b my-fix-branch develop
```

* Create your patch, **including appropriate test cases**.
Expand All @@ -70,6 +70,7 @@ Before you submit your merge request consider the following guidelines:
```shell
git commit -a
```

Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files.

* Build your changes locally to ensure all the tests pass:
Expand All @@ -79,7 +80,7 @@ Before you submit your merge request consider the following guidelines:
git push origin my-fix-branch
```

In Github, send a pull request to original master branch: f.e. `terraform-aws-vpc:master`.
In Github, send a pull request to original develop branch: f.e. `terraform-aws-vpc:develop`.
If we suggest changes, then:

* Make the required updates.
Expand All @@ -89,10 +90,10 @@ If we suggest changes, then:

If the PR gets too outdated we may ask you to rebase and force push to update the PR:

```shell
git rebase master -i
git push origin my-fix-branch -f
```
```shell
git rebase develop -i
git push origin my-fix-branch -f
```

_WARNING: Squashing or reverting commits and force-pushing thereafter may remove Github comments on code that were previously made by you or others in your commits. Avoid any form of rebasing unless necessary._

Expand All @@ -109,10 +110,10 @@ from the main (upstream) repository:
git push origin --delete my-fix-branch
```

* Check out the master branch:
* Check out the develop branch:

```shell
git checkout master -f
git checkout develop -f
```

* Delete the local branch:
Expand All @@ -121,10 +122,10 @@ from the main (upstream) repository:
git branch -D my-fix-branch
```

* Update your master with the latest upstream version:
* Update your develop with the latest upstream version:

```shell
git pull --ff upstream master
git pull --ff upstream develop
```

## <a name="info"></a> Info
Expand All @@ -136,5 +137,5 @@ Use the badge to sign-up.
[![Slack](https://philips-software-slackin.now.sh/badge.svg)](https://philips-software-slackin.now.sh)

[contribute]: CONTRIBUTING.md
[github]: https://github.com/philips-lam/terraform-aws-github-runner/issues
[github]: https://github.com/philips-lam/terraform-aws-github-runner/issues
npalm marked this conversation as resolved.
Show resolved Hide resolved
[slack]: https://philips-software.slack.com/home
Loading