fix: Honnor booting instance in runner pool #2801
Conversation
|
Oh, thank you! I have been working this on the clock (and therefore away from my work computer for the last week and a half); I didn't mean to leave it fallow as long as I did but the end of the year is always kind of a liminal time at work. I'll take a look when I'm on the clock tomorrow (Wednesday) -- this was much appreciated. |
|
@mckern @M1kep please can you have a look on the PR. I added tests and refactory the implementaiton so both registered instances as still booting instances are considered.
No problem, had a bit of time and thought let's dig in. I hope this helps. I will leave the PR open. Hopefully you have a bit of time early next year to check the implementation. |
npalm
force-pushed
the
fix/respect-booting-instances-pool
branch
from
194ea63 to
1d42c41
Compare
|
@M1kep thanks for the comments, will check asap |
Rebased off of the patch provided by Michael Poutre <[email protected]> in philips-labs/terraform-aws-github-runner#2590 and re-targeted against the develop branch. Co-authored-by: Ryan McKern <[email protected]>
I had a very different version of prettier installed globally; running `yarn run prettier --write` should hopefully be enough to get this fixed up and passing.
npalm
force-pushed
the
fix/respect-booting-instances-pool
branch
from
03f22d6 to
8a3984b
Compare
@mckern @M1kep Thanks for the work done in #2590 and #2733
When digging in today for review I found out the test are not running as expected. Bu fixing th test I decided also to take the changes you proposed in your PR into account. I would appreciate when you have a bit of time to check this PR.