Skip to content

Commit

Permalink
fix: restrict runner security group to only ingress (#3564)
Browse files Browse the repository at this point in the history
Runner security group is currently open.

This patch removes the default ingress rule security group to deny
everything.

More info on [this
documentation](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group#removing-all-ingress-and-egress-rules).
  • Loading branch information
ThomasLachaux authored Oct 26, 2023
1 parent c747139 commit e63fdc5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions modules/runners/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,8 @@ resource "aws_security_group" "runner_sg" {

vpc_id = var.vpc_id

ingress = []

dynamic "egress" {
for_each = var.egress_rules
iterator = each
Expand Down

0 comments on commit e63fdc5

Please sign in to comment.