Skip to content

Commit

Permalink
feat!: Add multi-runner capability (#2472)
Browse files Browse the repository at this point in the history
Migration:
- Does the main module needs to be redeployed after this feature is released? There is no change in Terraform version for the main module, so it will not require TF upgrade. There is only one change in main module, which is a breaking change, the variable runner_enable_workflow_job_labels_check is not available under this module as we now only support the flagrunner_enable_workflow_job_labels_check_all to check all/partial workflow labels to be present in the runner labels. Running TF apply on existing deployment will apply some changes done in internal modules to existing infrastructure.
- Impact on using internal (submodules). There are some changes in the webhook internal module as per this feature. So, If you have been using it directly, the changes will be towards accepting runner configuration (queue details and label matchers) as a single object instead of earlier configuration of scattered queue details and criteria to match the workflow labels against the runner labels.

Co-authored-by: Niek Palm <[email protected]>
Co-authored-by: Niek Palm <[email protected]>
Co-authored-by: navdeepg2021 <[email protected]>
  • Loading branch information
3 people committed Dec 28, 2022
1 parent c578f68 commit 564d7b8
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
25 changes: 25 additions & 0 deletions examples/multi-runner/lambdas-download/main.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
locals {
version = "<REPLACE_BY_GITHUB_RELEASE_VERSION>"
}

module "lambdas" {
source = "../../../modules/download-lambda"
lambdas = [
{
name = "webhook"
tag = local.version
},
{
name = "runners"
tag = local.version
},
{
name = "runner-binaries-syncer"
tag = local.version
}
]
}

output "files" {
value = module.lambdas.files
}
1 change: 1 addition & 0 deletions modules/webhook/lambdas/webhook/src/ssm/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const cleanEnv = process.env;
beforeEach(() => {
jest.resetModules();
jest.clearAllMocks();
jest.resetAllMocks();
process.env = { ...cleanEnv };
nock.disableNetConnect();
});
Expand Down

0 comments on commit 564d7b8

Please sign in to comment.