Skip to content

Commit

Permalink
feat: upgrade lambda runtime from 18x to 20x (#3682)
Browse files Browse the repository at this point in the history
## Description
This PR upgrades the node runtime to the latest LTS version on AWS. 

## Migration
- Ensure your AWS provider is supporting nodejs20x

## Updates
- Examples
- CI
- All dependencies bumped except middy/core see #3681

## Test

- [x] multi-runner
- [x] ephemeral with enabled pool

close: #3645

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
npalm and github-actions[bot] authored Dec 20, 2023
1 parent 3c78f65 commit 02dd3e6
Show file tree
Hide file tree
Showing 31 changed files with 493 additions and 504 deletions.
2 changes: 1 addition & 1 deletion .ci/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#syntax=docker/dockerfile:1.2
FROM node:18 as build
FROM node:20 as build
WORKDIR /lambdas
RUN apt-get update \
&& apt-get install -y zip \
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ARG VARIANT="18-bullseye"
ARG VARIANT="20-bullseye"
FROM mcr.microsoft.com/vscode/devcontainers/typescript-node:0-${VARIANT}
2 changes: 1 addition & 1 deletion .github/workflows/lambda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [18]
node: [20]
container:
image: node:${{ matrix.node }}
defaults:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ jobs:
steps:
- uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: 18
node-version: 20
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # ratchet:actions/checkout@v4
- name: Build dist
working-directory: lambdas
run: yarn install && yarn run test && yarn dist
run: yarn install --frozen-lockfile && yarn run test && yarn dist
- name: Get installation token
uses: philips-software/app-token-action@a37926571e4cec6f219e06727136efdd073d8657 # ratchet:philips-software/[email protected]
id: token
Expand Down
40 changes: 20 additions & 20 deletions examples/arm64/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/arm64/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ terraform output -raw webhook_secret

| Name | Version |
|------|---------|
| <a name="provider_random"></a> [random](#provider\_random) | 3.5.1 |
| <a name="provider_random"></a> [random](#provider\_random) | 3.6.0 |

## Modules

Expand Down
40 changes: 20 additions & 20 deletions examples/default/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/default/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ terraform output -raw webhook_secret

| Name | Version |
|------|---------|
| <a name="provider_random"></a> [random](#provider\_random) | 3.5.1 |
| <a name="provider_random"></a> [random](#provider\_random) | 3.6.0 |

## Modules

Expand Down
40 changes: 20 additions & 20 deletions examples/ephemeral/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/ephemeral/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ terraform output webhook_secret

| Name | Version |
|------|---------|
| <a name="provider_random"></a> [random](#provider\_random) | 3.5.1 |
| <a name="provider_random"></a> [random](#provider\_random) | 3.6.0 |

## Modules

Expand Down
36 changes: 18 additions & 18 deletions examples/lambdas-download/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 02dd3e6

Please sign in to comment.