Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[view] Font, Color 관련 docs 업데이트 #750

Merged
merged 3 commits into from
Oct 6, 2024
Merged

Conversation

pcwadarong
Copy link
Member

@pcwadarong pcwadarong commented Oct 3, 2024

Related issue

#749

Result

image

Work list

  • 이슈 참고만 작성되어 있었던 font, color 부분을 이번에 업데이트한 내용으로 반영하여 작성하였습니다.
  • 제목을 모두 대문자로 시작하도록 수정하였습니다.

Discussion

  • 가독성을 위해 font 하위의 각 내용을 큰 코드 덩어리로 감싸거나, 단위만 ``` 를 이용하여 감싸는 등 여러가지 방법을 고민해보았으나 현재 작성되어 있는 바로는 (commit label, namespace를 제외) '코드'를 제외하곤 감싸지 않은 것 같아 최대한 덜어내려고 하였습니다.
  • 추가적으로 첨언하거나, 변경하면 좋을 부분이 있다면 편히 말씀해주시면 수정해서 다시 올리겠습니다!!

@pcwadarong pcwadarong self-assigned this Oct 3, 2024
@pcwadarong pcwadarong requested review from a team as code owners October 3, 2024 13:59
Copy link
Contributor

@xxxjinn xxxjinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생각도 못하고 있었는데 너무 좋은 것 같아요!🙂🙂🙂🙂🙂👍

@@ -181,22 +181,40 @@ VerticalClusterList

# Manifesto

## 색상
## [색상](https://github.com/githru/githru-vscode-ext/blob/main/packages/view/src/styles/_colors.scss)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

링크 달아주신 것도 너무 좋은 것 같아요😍😍💡

Copy link
Contributor

@shgusgh12 shgusgh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 자세한 설명 좋습니다!!! 👍

Copy link
Contributor

@ytaek ytaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍
👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍
👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍

@pcwadarong pcwadarong merged commit 0556deb into githru:main Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants