[vscode] git 연결된 레포지토리가 확장 개발 호스트에서 실행되지 않는 버그 임시 수정 #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
approved these changes
Sep 27, 2024
Comment on lines
+90
to
+94
| //FIXME - For repositories where git exists, analyzedData is initially assigned as undefined. | ||
| // if (!analyzedData) { | ||
| // this.dispose(); | ||
| // throw new Error("Project not connected to Git."); | ||
| // } |
There was a problem hiding this comment.
음. 이 부분 @DaYoung-woo 님이 #679 에서 수정해주신 부분 같은데
한번 같의 논의해보시면 좋을 것 같습니다!
혹시 지금 아예 동작이 안되는 상황이라면 일단 바로 반영해주시구요!
There was a problem hiding this comment.
아예 확장개발호스트가 열리지 않는 상황이라
해당 내용 issue로 생성 후 해당 PR은 merge 하도록 하겠습니다.
Sang-minKIM
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
dispose됩니다.Result
Work list
analyzedData값의 할당 유무로 git 연결 여부를 확인하였으나 git 연결된 경우에도analyzedData에는 undefined가 할당됩니다.Discussion
analyzedData에 항상undefined값이 할당되는 원인을 모르겠습니다. 🥲