Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README Contributors 내용 수정 #543

Merged
merged 1 commit into from
Jul 20, 2024
Merged

README Contributors 내용 수정 #543

merged 1 commit into from
Jul 20, 2024

Conversation

choisohyun
Copy link
Contributor

@choisohyun choisohyun commented Jul 19, 2024

Related issue

#355

Result

  • all contributor를 제거하고 contrib 이미지로 교체합니다.

Work list

노출 예시입니다.


Discussion

  • all contributor는 사람이 계속해서 코멘트를 달아야 추가되는 형식인 것 같습니다. 이미 누락된 contributor도 많은 것 같아, owner/repo 를 통해 이미지를 만들어 주는 것으로 교체해 보았습니다!

@choisohyun choisohyun self-assigned this Jul 19, 2024
@choisohyun choisohyun requested review from a team as code owners July 19, 2024 13:52
Copy link
Contributor

@ytaek ytaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첫 PR 부터 강렬합니다!!!!

Comment on lines +16 to +18
<a href="https://github.com/githru/githru-vscode-ext/graphs/contributors">
<img src="https://contrib.rocks/image?repo=githru/githru-vscode-ext" />
</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

으아니! 이런 신박한 방법이 있었단 말인가요?!!!!! 😱😱😱😱😱😱😱😱😱😱😱😱😱😱😱😱

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(질문) 이건 외부 서비스를 이용한걸까요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! 밑에 적어주신 댓글에도 깃허브 링크가 있긴 한데 https://contrib.rocks 이쪽입니다!

@bbanderson bbanderson self-requested a review July 20, 2024 04:00
Copy link
Contributor

@bbanderson bbanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우 좋은 방법이네요~!😄
이슈 들어가봤는데, 프사 같은 경우에는 캐싱이 걸리는지 이미지 업데이트가 잘 안된다는 글을 본 것 같은데 이게 최근에도 이런건지는 잘 모르겠네요..!(크게 중요하진 않겠지만)
이후에 만약 사용하다가 해당 이슈가 마음에 걸리면, 다른 서비스도 이용해보거나, 아니면 저희 내부에서 레포 하나 파서 github api&workflow로 꾸며봐도 챌린징하고 재밌을 것 같네요!

@choisohyun
Copy link
Contributor Author

@bbanderson
오호 이런 이슈도 있군요..! 요게 또 이미지로 만들어 주는거라 각각 깃헙 링크 연결이라던지 안되는 게 또 있어서.. 직접 만들어보는것도 좋을것 같네요!

@choisohyun choisohyun linked an issue Jul 20, 2024 that may be closed by this pull request
@choisohyun
Copy link
Contributor Author

머지하겠습니다 🙇

@choisohyun choisohyun merged commit 26ac95f into main Jul 20, 2024
2 checks passed
@choisohyun choisohyun deleted the docs/355 branch July 20, 2024 13:21
@ytaek ytaek added this to the v0.7.0 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributor-bot 내용 수정
4 participants