Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[View] The message property does not exist in the commit type. #70

Closed
jin-Pro opened this issue Sep 3, 2022 · 0 comments · Fixed by #72
Closed

[View] The message property does not exist in the commit type. #70

jin-Pro opened this issue Sep 3, 2022 · 0 comments · Fixed by #72
Assignees
Labels

Comments

@jin-Pro
Copy link
Member

jin-Pro commented Sep 3, 2022

export type Commit = {
  id: string;
  parentIds: string[];
  author: GitHubUser;
  committer: GitHubUser;
  authorDate: Date;
  commitDate: Date;
  diffStatistics: DiffStatistics;

  // fill necessary properties...
};
// commit data
commit
ㄴ id : "2a7a93cde9c9f74d5f05c1d0fb1da8e96da7057b"
ㄴ parentIds :  ['7d8569355a24bf79c84c2970f88a62c20261c3f5']
ㄴ author : {names: Array(1), emails: Array(1)}
ㄴ committer : {names: Array(1), emails: Array(1)}
ㄴ authorDate : "2018-09-13T07:30:42.000Z"
ㄴ commitDate : "2018-09-13T07:30:42.000Z"
ㄴ diffStatistics : {insertions: 0, deletions: 196, files: {…}}
ㄴ message : "WIP"

Commit Type에 Message Property를 추가하고자 합니다.

@jin-Pro jin-Pro self-assigned this Sep 3, 2022
jin-Pro added a commit to jin-Pro/githru-vscode-ext that referenced this issue Sep 3, 2022
enhance(view): CommitNode Type add taskId Property

feat(view): Detail Component
@jin-Pro jin-Pro changed the title [View] : The message property does not exist in the commit type. [View] The message property does not exist in the commit type. Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant