t0061: fix test for argv[0] with spaces (MINGW only) #356
Conversation
|
@dscho thanks for the pointer about gcc build! Didn't realize that default makefile doesn't use VS at all. I have updated the commit message; does that look good now? |
|
This PR is continuation of git#651 which I have created on wrong repo by mistake. |
The test was originally designed for the case where user reported that setting GIT_SSH to a .bat file with spaces in path fails on Windows: git-for-windows#692 The test has two different problems: 1. It succeeds with AND without fix eb7c786 that addressed user's problem. This happens because the core problem was misunderstood, leading to conclusion that git is unable to start any programs with spaces in path on Win7. But in fact a) Bug only affected cmd.exe scripts, such as .bat scripts b) Bug only happened when cmd.exe received at least two quoted args c) Bug happened on any Windows (verified on Win10). Therefore, correct test must involve .bat script and two quoted args. 2. In Visual Studio build, it fails to run, because 'test-fake-ssh.exe' is copied away from its dependencies 'libiconv.dll' and 'zlib1.dll'. Fix both problems by using .bat script instead of 'test-fake-ssh.exe'. NOTE: With this change, the test now correctly fails without eb7c786. Signed-off-by: Alexandr Miloslavskiy <[email protected]>
SyntevoAlex
force-pushed
the
#0191_t0061_fixes
branch
from
1921cf9 to
ab81cee
Compare
|
OK, I have updated the patch. Different code style preferences, I guess. |
|
/submit |
|
Submitted as [email protected] |
|
This branch is now known as |
|
This patch series was integrated into pu via git@e73c6f3. |
|
This patch series was integrated into pu via git@e698a13. |
|
This patch series was integrated into pu via git@0f47be2. |
|
This patch series was integrated into pu via git@661c071. |
|
This patch series was integrated into next via git@0fdb87d. |
|
This patch series was integrated into pu via git@4487d83. |
|
This patch series was integrated into pu via git@b6d1e92. |
|
This patch series was integrated into pu via git@df1c917. |
|
This patch series was integrated into pu via git@cdadaa3. |
|
This patch series was integrated into pu via git@424663d. |
|
This patch series was integrated into next via git@424663d. |
|
This patch series was integrated into master via git@424663d. |
|
Closed via 424663d. |
The test was originally designed for the case where user reported
that setting GIT_SSH to a .bat file with spaces in path fails on
Windows: git-for-windows#692
The test has two different problems:
problem. This happens because the core problem was misunderstood,
leading to conclusion that git is unable to start any programs with
spaces in path on Win7. But in fact
a) Bug only affected cmd.exe scripts, such as .bat scripts
b) Bug only happened when cmd.exe received at least two quoted args
c) Bug happened on any Windows (verified on Win10).
Therefore, correct test must involve .bat script and two quoted args.
is copied away from its dependencies 'libiconv.dll' and 'zlib1.dll'.
Fix both problems by using .bat script instead of 'test-fake-ssh.exe'.
NOTE: With this change, the test now correctly fails without eb7c786.
Signed-off-by: Alexandr Miloslavskiy [email protected]