Activity stream #1732
Activity stream #1732
Conversation
app/retail/views.py
Outdated
| 'new_bounty': 'fa-money-bill-alt', | ||
| 'work_done': 'fa-check-circle', | ||
| } | ||
| def add_view_props(activity): |
There was a problem hiding this comment.
E306 expected 1 blank line before a nested definition, found 0
Codecov Report
@@ Coverage Diff @@
## master #1732 +/- ##
==========================================
- Coverage 29.08% 29.04% -0.05%
==========================================
Files 134 134
Lines 10101 10133 +32
Branches 1328 1338 +10
==========================================
+ Hits 2938 2943 +5
- Misses 7058 7085 +27
Partials 105 105
Continue to review full report at Codecov.
|
ghost
assigned
| } | ||
|
|
||
|
|
||
| def add_view_props(activity): |
app/app/urls.py
Outdated
| @@ -170,6 +170,8 @@ | |||
| url(r'^mission/?', retail.views.mission, name='mission'), | |||
| re_path(r'^results/?(?P<keyword>.*)/?', retail.views.results, name='results_by_keyword'), | |||
| re_path(r'^results/?', retail.views.results, name='results'), | |||
| url(r'^activity/?', retail.views.activity, name='activity'), | |||
| url(r'^mission/?', retail.views.mission, name='mission'), | |||
There was a problem hiding this comment.
mission is in here twice now
|
|
||
|
|
||
| def token_by_name(name): | ||
| for token in tokens: |
There was a problem hiding this comment.
tokens is undefined in this scope.
There was a problem hiding this comment.
yea i fixed this in master and now we good https://gitcoin.co/activity
There was a problem hiding this comment.
I pushed a fix as soon as it popped on rollbar the other day? 🤔 2325aa7
There was a problem hiding this comment.
thx; i think i must have fixed another 500 issue on /activity then
WIP to review
fixes #925