Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #700

Merged
merged 2 commits into from
Mar 21, 2020
Merged

Update README.md #700

merged 2 commits into from
Mar 21, 2020

Conversation

lucidlemon
Copy link
Contributor

minor typo regarding alignment of an object

minor typo regarding alignment of an object
@ankon
Copy link
Contributor

ankon commented Mar 18, 2020

pres doesn't seem to be declared for the ITextOpts interface, and the constant name AlignH.center also seems to point to this being the align option.

PptxGenJS/types/index.d.ts

Lines 1323 to 1381 in 518667b

export interface ITextOpts extends PositionOptions, OptsDataOrPath, FontOptions {
align?: HAlign
autoFit?: boolean
bodyProp?: {
autoFit?: boolean
align?: TEXT_HALIGN
anchor?: TEXT_VALIGN
lIns?: number
rIns?: number
tIns?: number
bIns?: number
vert?: 'eaVert' | 'horz' | 'mongolianVert' | 'vert' | 'vert270' | 'wordArtVert' | 'wordArtVertRtl'
wrap?: boolean
}
bold?: boolean
breakLine?: boolean
bullet?:
| boolean
| {
type?: string
code?: string
style?: string
startAt?: number
}
charSpacing?: number
color?: string
fill?: ShapeFill
glow?: IGlowOptions
hyperlink?: HyperLink
indentLevel?: number
inset?: number
isTextBox?: boolean
italic?: boolean
lang?: string
line?: Color
lineIdx?: number
lineSize?: number
lineSpacing?: number
margin?: Margin
outline?: {
color: Color
size: number
}
paraSpaceAfter?: number
paraSpaceBefore?: number
placeholder?: string
rotate?: number
rtlMode?: boolean
shadow?: IShadowOptions
shape?: SHAPE_NAME
shrinkText?: boolean
strike?: boolean
subscript?: boolean
superscript?: boolean
underline?: boolean
valign?: VAlign
vert?: 'eaVert' | 'horz' | 'mongolianVert' | 'vert' | 'vert270' | 'wordArtVert' | 'wordArtVertRtl'
wrap?: boolean
}

@gitbrent
Copy link
Owner

This is not correct. align is the proper way to align text...

@lucidlemon
Copy link
Contributor Author

ah jesus my bad! i didn't mean to change the key - but the var pptx is undefined as you are referencing pres, fixed that now

@gitbrent gitbrent merged commit 4e5c595 into gitbrent:master Mar 21, 2020
@gitbrent
Copy link
Owner

@lucidlemon - thanks for the fix!

gitbrent added a commit that referenced this pull request Mar 21, 2020
@lucidlemon lucidlemon deleted the patch-1 branch March 23, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants