Removed error thrown while rendering Multi Type chart containing Area #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data label position is being set to outEnd for Multitype charts that contain an area chart as the other chart type would enable inclusion of that line. Hence either the suggested changes can be made or the entire line checking the condition can be removed.
|
Hi @KrishnaTejaReddyV , Thanks for the submission. Can you provide some code/screencaps showing the issue before and after the fix? |
|
Attached the images with error before change, output before change and output after change |
gitbrent
approved these changes
Sep 11, 2018
|
Thanks @KrishnaTejaReddyV ! |
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
Removed error thrown while rendering Multi Type chart containing Area
ericrockey
pushed a commit
to WeTransfer/PptxGenJS
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data label position is being set to outEnd for Multitype charts that contain an area chart as the other chart type would enable inclusion of that line. Hence either the suggested changes can be made or the entire line checking the condition can be removed.