Better client side support #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitbrent
pushed a commit
that referenced
this pull request
Jun 22, 2017
gitbrent
pushed a commit
that referenced
this pull request
Jun 22, 2017
gitbrent
pushed a commit
that referenced
this pull request
Jun 22, 2017
|
Hi @santi-git , Thanks for the PR and doing to bower registration! I've incorporated the changes into the project. Also, thanks for getting me started with gulp - i've been meaning to setup a workflow for a bundled file for a while now. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR's intent is to improve the experience of using the library on the client side, the changes that were made are the following:
If the PR is merged, the version tag should be bumped and the new version should be uploaded to bower, given there is no contribution instructions I did my best to be us tidy as possible. I don't now how you handle builds internally, or if you do it at all so I tried not to go too far with that.
I'm using pptxgen at work and this improvement would make it easier for me to use it.
Hope it helps!