Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on Firefox for Mac, no issues on Firefox for windows. #81

Closed
alexanderdevm opened this issue May 9, 2017 · 6 comments
Closed
Assignees
Milestone

Comments

@alexanderdevm
Copy link

Does not work, as in firefox for mac does not download the ppt file.

@gitbrent gitbrent self-assigned this May 10, 2017
@gitbrent
Copy link
Owner

Hi @alexanderdevm,

I'm not able to reproduce this: I downloaded Firefox, opened the local pptxgenjs-demo.html page, clicked the Basic Slide Demo button and a PowerPoint was opened in Keynote.

Do you see any output in the Console that would indicate the issue?

@alexanderdevm
Copy link
Author

After upgrading firefox to the latest version 53 on my first Mac, the issue disappeared, and i was able to reproduce the issue on older version of Firefox on different Mac.

  • First Mac,, Mac sierra 10.12.4, Firefox 53.0
  • Second Mac, Mac sierra 10.12.4 , Firefox 48.0.4

I have also tried local pptxgenjs-demo.html, and the page on your demo portal.

So it looks like unless your of Firefox 53 Mac, you will run into this issue.

@rwhitmore90
Copy link

I have noticed this on Firefox for windows version 44 and 46. No errors on the console but when I started to look through the save procedure I noticed the blob URL would begin with blob:null/. Could that be the issue?

As soon as I upgraded Firefox, issue disappeared. Unfortunately my client has either Firefox 46 or IE11. IE11 works for PptxGenJS but my requirements are to convert a d3 svg into a png and then place into a powerpoint file which does not work in IE11.

gitbrent pushed a commit that referenced this issue May 17, 2017
@gitbrent
Copy link
Owner

Hi @alexanderdevm @rwhitmore90,

Thanks for reporting this.

It looks like the element is being removed before Firefox can grab it, as seen in this StackOverflow answer.

I've added a delay before removing the element which should fix the issue.

Please try the using the latest code and let me know how it goes.

@gitbrent gitbrent added this to the v1.5.0 milestone May 17, 2017
@rwhitmore90
Copy link

It fixed it for me, thank you!

@gitbrent
Copy link
Owner

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants