Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't override margin with 0 #78

Closed
scottmtraver opened this issue Apr 28, 2017 · 1 comment
Closed

Can't override margin with 0 #78

scottmtraver opened this issue Apr 28, 2017 · 1 comment
Assignees
Milestone

Comments

@scottmtraver
Copy link

opts.margin = opts.marginPt || opts.margin || 0.5;

One cannot override options margin with a 0 because it is JS 'falsey' and the 0.5 is the result of this line. I will fix it soon when I get the chance.

@gitbrent gitbrent self-assigned this Apr 29, 2017
@gitbrent gitbrent added this to the v1.5.0 milestone Apr 29, 2017
gitbrent pushed a commit that referenced this issue Apr 29, 2017
@gitbrent
Copy link
Owner

Hi @scottmtraver ,

Thanks for reporting this!

I've fixed the issue in both addTable() and addSlidesForTable().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants