Add new 'lang' text option to enable Chinese Word font_face to take effect

[eddyclock]

Hi @gitbrent ,

I have added some text with Chinese word "你好" with Chinese font_face = 微軟正黑體 but the chinese cannot reflect correctly.

var pptx = new PptxGenJS();
var slide = pptx.addNewSlide();
//chinese word with chinese font
slide.addText('你好',  { x:0.5, y:1, w:3, font_size:500 , font_face:'微軟正黑體'});
pptx.save('PptxGenJS-ChineseWord-Font-微軟正黑體');

I tried to add new option with "zh-tw"

if (opts.lang == "zh-TW"){
	startInfo = '<a:rPr lang="zh-TW" altLang="en-US" ';
}else{
	startInfo = '<a:rPr lang="en-US" ';
}
startInfo += ( opts.bold      ? ' b="1"' : '' );
startInfo += ( opts.font_size ? ' sz="'+ Math.round(opts.font_size) +'0"' : '' ); 
startInfo += ( opts.italic    ? ' i="1"' : '' );
startInfo += ( opts.underline || opts.hyperlink ? ' u="sng"' : '' );
// not doc in API yet: startInfo += ( opts.char_spacing ? ' spc="' + (text_info.char_spacing * 100) + '" kern="0"' : '' ); // IMPORTANT: Also disable kerning; otherwise text won't actually expand
startInfo += ' dirty="0" smtClean="0">';
// Color and Font are children of <a:rPr>, so add them now before closing the runProperties tag
if ( opts.color || opts.lang) {
	if ( opts.color ) startInfo += genXmlColorSelection( opts.color );
	if ( opts.font_face ) {
		startInfo += '<a:latin typeface="' + opts.font_face + '" pitchFamily="34" ';
		if (opts.lang == "zh-TW"){
			startInfo += 'charset="0"/><a:ea typeface="' + opts.font_face + '" pitchFamily="34" charset="-120"/>';
		}
		else{
			startInfo += 'charset="0"/><a:cs typeface="' + opts.font_face + '" pitchFamily="34" charset="0"/>';
		}
	}
}

Just my small input.
Eddy Kwok

[gitbrent]

Hi @eddyclock ,

I've checked in changes to add a new lang option - see if it works correctly now.

var pptx = new PptxGenJS();
var slide = pptx.addNewSlide();
//chinese word with chinese font
slide.addText('你好',  { x:0.5, y:1, w:3, font_size:50 , font_face:'微軟正黑體', lang:'zh-TW' });
pptx.save('PptxGenJS-ChineseWord-Font-微軟正黑體');

[eddyclock]

HI @gitbrent

Sorry for long waiting.

It is not correct. I have tried to generate XML file from PowerPoint.

if lang = "zh-TW", I found that there are some key factors as below:

<a:rPr lang="zh-TW" altLang="en-US" ....>
<a:cs typeface ... charset="0"> ...change to <a:ea ... charset="-120">

Hope this can help.
Regards,
Eddy Kwok

[gitbrent]

Hi @eddyclock ,

Thanks for letting me know. Both 'ea' and 'cs' are set to charset="-120" now.

[LawlietNot]

Hi @gitbrent ,
I found a bug
if set text lang="zh-CN", use office 2007 open fail ,prompt repair and then blank page.
if 2010

I do not know pptx xml,so i tried to modify the xml for

<a:latin charset="-122" pitchFamily="34" typeface="微软雅黑"/>
	<a:ea charset="-122" pitchFamily="34" typeface="微软雅黑"/>
	<a:cs charset="-120" pitchFamily="34" typeface="微软雅黑"/>

And at label:ea must be before label:cs,otherwise use office 2007 still is fails.

Is this possible only for Simplified Chinese.

[gitbrent]

Hi @LawlietNot,

I've re-ordered the one place where cs was before ea. Let me know if this fixes the issue.

Also, would you mind creating a simple "hello world" PPT using 2007 and attach it? I'd like to see what may be causing these 2007 issues. Thanks!

[eddyclock]

Hi @LawlietNot
It is fixed and thanks for your help.
Eddy