Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quotes mobile css fix [fixes #216] #228

Conversation

sarthak-kumar-shailendra
Copy link
Contributor

@sarthak-kumar-shailendra sarthak-kumar-shailendra commented Oct 8, 2023

[Fixes #216]
This PR resolves quotes mobile css overflow issue.

The issue was because of fixed height mentioned h-96 in quotes page file. So I have changed it to min-h-screen.
(Here I have assumed we cannot change the font size)

Screenshot 2023-10-08 at 11 56 19 PM

Pls check the UI in different devices and suggest any changes if required @samanyougarg

@vercel
Copy link

vercel bot commented Oct 8, 2023

@sarthak-kumar-shailendra is attempting to deploy a commit to the Ved Vyas Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@sarthak-kumar-shailendra
Copy link
Contributor Author

Hare Krishna
pls review @samanyougarg

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bhagavad-gita ✅ Ready (Inspect) Visit Preview Jan 20, 2024 6:08pm

@vercel vercel bot temporarily deployed to Preview – bhagavad-gita January 20, 2024 18:08 Inactive
@samanyougarg
Copy link
Member

This is adding a lot of unneeded whitespace on the top and bottom of the quotes. Please fix it:
CleanShot 2024-01-20 at 23 41 11@2x

Copy link
Member

@samanyougarg samanyougarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace needs fixing.

@sarthak-kumar-shailendra
Copy link
Contributor Author

@samanyougarg pls check now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Overflow of quotes content for large quotes in mobile view.
2 participants