Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 fix: Overflow of quotes in footer on mobile view #225

Closed
wants to merge 2 commits into from
Closed

📝 fix: Overflow of quotes in footer on mobile view #225

wants to merge 2 commits into from

Conversation

nawinsharma
Copy link

@nawinsharma nawinsharma commented Oct 2, 2023

What?

This PR addresses the issue of quote overflow #216 in the footer when the website is viewed on small devices.

Why?

The overflow of quotes in the footer on small devices created a poor user experience, as it made the content difficult to read and interact with. This problem needed to be resolved to ensure that our website is accessible and functional across all devices.

Screenshots

Before
image

After
image

@vercel
Copy link

vercel bot commented Oct 2, 2023

@NawinKumarSharma is attempting to deploy a commit to the Ved Vyas Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@nawinsharma
Copy link
Author

@eht-ck please review the PR #225

@sarthak-kumar-shailendra
Copy link
Contributor

I believe the task was supposed to make the div flexible and not reduce the font size. @NawinKumarSharma @eht-ck

Copy link
Author

@nawinsharma nawinsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sarthak-kumar-shailendra @eht-ck , Please review my changes, I wrapped the entire content in a div with the class flex flex-col h-screen, which sets up a flex container that occupies the full height of the viewport.Inside this container, I used flex-1 on the main content area to make it occupy the available vertical space and grow as needed, preventing overflow and overlap with the footer. #225

@nawinsharma
Copy link
Author

@eht-ck please review

@sarthak-kumar-shailendra
Copy link
Contributor

Screenshot 2023-10-08 at 3 28 49 PM

There's extra space after footer which doesn't appear aesthetically pleasing.

@nawinsharma
Copy link
Author

@sarthak-kumar-shailendra i have made the changes #225 which looks nice to the mobile device as well as normal screen . please clarify your revuew. The screenshot of my changes are there in first comment.

@nawinsharma nawinsharma closed this by deleting the head repository Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants