convert(): plug potential memory leak

When the result of conversion is identical to the original argument, we should make sure that the temporary buffer was released. Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows · Feb 14, 2017 · 7212cb8 · 7212cb8
1 parent 903eac5
commit 7212cb8
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
@@ -3464,6 +3464,10 @@ arg_heuristic_with_exclusions (char const * const arg, char const * exclusions,
   // Don't allocate memory if no conversion happened.
   if (!strcmp (arg, stack_path))
     {
+      if (arg != stack_path)
+        {
+          free (stack_path);
+        }
       return ((char *)arg);
     }
   arg_result = (char *)realloc (stack_path, strlen (stack_path)+1);