git-cvsexportcommit.perl: Force crlf translation #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this is Git's own source code, the contribution needs to conform to the Git project's requirements, in particular the commit message. How about this instead? In addition, I would like to ask whether you tested this in Git for Windows' SDK, using Git's own test suite? |
When using cvsnt + msys + git, it seems like the output of cvs status had \r\n in it, and caused the command to fail. This fixes that. Signed-off-by: Dustin Spicuzza <[email protected]>
|
I've changed the commit as asked. I did not test it with the test suite, I was hoping that travis-ci or equivalent would do that for me, though now I see that it doesn't run the tests (strange). |
Sadly, we do not have CI running on Windows in place. Yet. Will test manually, but that will have to wait until tomorrow. |
|
Seems to pass. Thanks! |
dscho
added a commit
that referenced
this pull request
Nov 4, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
pushed a commit
that referenced
this pull request
Nov 5, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
pushed a commit
that referenced
this pull request
Nov 9, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
pushed a commit
that referenced
this pull request
Nov 10, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
pushed a commit
that referenced
this pull request
Nov 10, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
added a commit
that referenced
this pull request
Nov 11, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
added a commit
that referenced
this pull request
Nov 11, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
pushed a commit
that referenced
this pull request
Nov 11, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
pushed a commit
that referenced
this pull request
Nov 11, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
pushed a commit
that referenced
this pull request
Nov 12, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
pushed a commit
that referenced
this pull request
Nov 13, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
pushed a commit
that referenced
this pull request
Nov 14, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
pushed a commit
that referenced
this pull request
Nov 16, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho
added a commit
that referenced
this pull request
May 7, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 7, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 8, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 9, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 9, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 10, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 10, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 13, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/git
that referenced
this pull request
May 13, 2019
This used to be "Merge pull request git-for-windows#938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/git
that referenced
this pull request
May 13, 2019
This used to be "Merge pull request git-for-windows#938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 14, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 14, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 14, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 21, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 22, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 25, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Jun 4, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Jun 8, 2019
This used to be "Merge pull request #938 from virtuald/patch-1" git-cvsexportcommit.perl: Force crlf translation Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug encountered when using cvsnt + msys + git. It seems like the output of
cvs statushad \r\n in it, and caused the command to fail. This fixes that.